Iron's Spells 'n Spellbooks

Iron's Spells 'n Spellbooks

10M Downloads

[Bug] Apotheosis spellbook modifiers do not work when the book is held in offhand

aallfik11 opened this issue ยท 5 comments

commented

Observed behaviour

When putting a spellbook into the offhand, all the buffs from apotheosis like cast time reduction, bonus mana etc. no longer apply

Expected behaviour

When putting a spellbook into the offhand, their additional stats and modifiers should apply
(I'm on a version 1 older than newest but I haven't noticed this problem being mentioned in the changelog)

Steps to reproduce

  1. Have iron's spellbooks and apotheosis installed (I'm doing it on ATM9 with Unobtainium Spellbook if that matters)
  2. Reforge the spellbook to have some observable, high bonuses (like 70% cast time reduction/cooldown reduction)
  3. Try casting a spell in the main and offhand, observing that their cast time and cooldown differ

Server Type

Dedicated Server

Crashlog

No response

Iron's Spells N Spellbooks version

1.20.1-2.2.1

Forge version

1.20.1 - 47.2.19

Other mods

Playing on Allthemods 9 version 0.2.39

commented

fixed in 3.0.0

commented

could add EquipmentSlot.OFFHAND in the array here, should apply then

public static final LootCategory SPELLBOOK = LootCategory.register(LootCategory.SWORD, "spellbook", s-> s.getItem() instanceof SpellBook, arr(EquipmentSlot.MAINHAND));

commented

@aallfik11 do other items, such as bows, give their attribute bonus while in the offhand?

commented

@aallfik11 do other items, such as bows, give their attribute bonus while in the offhand?

I must admit I haven't tested it, but I imagine that would be the case, given that apotheosis supports shields as well.