Iron's Spells 'n Spellbooks

Iron's Spells 'n Spellbooks

11M Downloads

[Bug] Memory Leak of Client Player

pietro-lopes opened this issue ยท 3 comments

commented

Observed behaviour

Client Player is leaked to Main Menu

Expected behaviour

No leak

Steps to reproduce

Join game, exit game to Main menu and Client Player is leaked.

SpellBarOverlay holds an instance of:
SpellSelectionManager which holds a player

image

Server Type

Single Player

Crashlog

No response

Iron's Spells N Spellbooks version

1.21-3.4.4

Forge version

1.21.1 - 21.1.12

Other mods

No response

commented

@pietro-lopes Is this creating an actual issue or just something that can be cleaned up?

commented

This is the kind of leak that does not grow, but it is nice to be cleaned in case the player joins a new world.
With this leak, the player when joining a new world will have at some point 2 instances, instead of trying to spin the new one only.
This is negligible on vanilla mc, but in modded and packs like ATM, Client Level can be huge

commented

fixed in 3.4.5