Iron's Spells 'n Spellbooks

Observed behaviour

Here is when SyncedSpellData is passed to new MagicData, but SyncedSpellData contains livingEntity, which (as it came from old) still refers to dead player, causing it to leak.

irons-spells-n-spellbooks/src/main/java/io/redspace/ironsspellbooks/player/ServerPlayerEvents.java

Lines 283 to 285 in f045028

    
           MagicData oldMagicData = MagicData.getPlayerMagicData(event.getOriginal()); 
        
           MagicData newMagicData = MagicData.getPlayerMagicData(event.getEntity()); 
        
           newMagicData.setSyncedData(oldMagicData.getSyncedData());

Expected behaviour

No leak

Steps to reproduce

Login,
/kill @s
check objects

Server Type

Single Player

Crashlog

No response

Iron's Spells N Spellbooks version

3.4.4

Forge version

21.1.12

Other mods