Iron's Spells 'n Spellbooks

Iron's Spells 'n Spellbooks

24M Downloads

[Bug] Recruit mod and Iron's Spells 'n Spellbooks causes crashes.

Max-P-17 opened this issue ยท 2 comments

commented

Observed behaviour

In Minecraft 1.20.1 (FORGE), the newest version of the Recruit mod (1.13.1) causes a crash when the Summon Horse Spell from Iron's Spells 'n Spellbooks is used.

Expected behaviour

The Summon Horse Spell from Iron's Spells 'n Spellbooks summons a horse when used.

Steps to reproduce

  1. Download newest versions of ISS and Recruits.
  2. Cast Summon Horse Spell.
  3. Crash.

Server Type

Dedicated Server

Crashlog

https://gist.github.com/Max-P-17/5f4998631e6dff72c9f6464cdc35d25a

Iron's Spells N Spellbooks version

1.20.1-3.4.0.7

Forge version

1.20.1

Other mods

Recruit mod (1.20.1-1.13.1)

Crashlog Check

  • I understand if this is a crashbug and I did not attach a crashlog, this will not be handled
commented

It's due to them replacing the navigation, making it async

https://github.com/talhanation/recruits/blob/main/src/main/java/com/talhanation/recruits/entities/ai/navigation/RecruitsHorsePathNavigation.java

considering this fix it seems to be only intended when a recruit is using it

talhanation/recruits@0343c6e#diff-8f06cc53a581ef3269819486b1255477575ef60ac42430fff6f391fc743a1ebe

so the crash may be fixed in the next version

not sure if you want to throw an exception when adding that goal to the entity though - i know mc does it for its own follow owner goal, but logging an error is probably the better option here (and then potentially not starting the goal)

commented

no longer crashes in 3.11.0, but any fix would need to be on their end