Observed behaviour

Certain spell effects, such as those created by Black Hole and Frostwave, are bypassing PVP rules. While damage rules are being observed, the secondary effects, such as slow and gravity respectively, are not.

This is happening under conditions where they should not. The following settings were tested:

• Server PVP OFF
• Server PVP ON / TEAM PVP OFF (and joined) / PVP Flagging NOT installed
• Server PVP ON / TEAM PVP OFF (and joined) / PVP Flagging installed with PVP toggled OFF
• Server PVP ON / TEAM not joined / PVP Flagging installed with PVP toggled OFF

Expected behaviour

When PVP is not enabled, either due to server settings, team PVP settings, or when PVP Flagging is installed and toggled OFF (and in combination with the other two settings), spell effects should have no affect, as happens where damage is concerned.

Steps to reproduce

1. Disable PVP for participants
2. Cast a spell which produces a secondary effect, such as Black Hole or Frostwave near participant
3. Participant should experience the secondary effects of the spells sans damage

Server Type

Dedicated Server

Crashlog

No response

Iron's Spells N Spellbooks version

1.21.1-3.12.1

Forge version

NeoForge v1.21.1 - 21.1.172

Other mods

accessories-neoforge-1.1.0-beta.42+1.21.1.jar
accessories_cclayer-9.3.1-beta.27+1.21.1-neoforge.jar
additional_attributes-1.21.1-1.2.2.jar
adventuredungeons-neoforge-1.21-1.3.1.jar
alshanex_familiars-1.21.1_v2.0_HotFix2.jar
Amplified_Nether_1.21.x_v1.2.8.jar
ApothicAttributes-1.21.1-2.8.1.jar
appleskin-neoforge-mc1.21-3.0.5.jar
architectury-13.0.8-neoforge.jar
ascendant_mobs-1.3.0-neoforge-1.21.1.jar
atlas_api-1.21.1-1.1.0.jar
automodpack-mc1.21.1-neoforge-4.0.0-beta35.jar
bettercombat-neoforge-2.2.4+1.21.1.jar
betterdays-1.21.1-3.1.1.1-NEOFORGE.jar
bookshelf-neoforge-1.21.1-21.1.62.jar
cloth-config-15.0.140-neoforge.jar
Controlling-neoforge-1.21.1-19.0.5.jar
CraftTweaker-neoforge-1.21.1-21.0.27.jar
dummmmmmy-1.21-2.0.7-neoforge.jar
DungeonsAriseSevenSeas-1.21.x-1.0.3.2-neoforge.jar
dynamictrees-neoforge-1.21.1-1.5.0-BETA04.jar
easy_npc-neoforge-1.21.1-5.9.0.jar
enchdesc-neoforge-1.21.1-21.1.7.jar
entityjs-1.2.3-1.21.jar
fzzy_config-0.6.9+1.21+neoforge.jar
geckolib-neoforge-1.21.1-4.7.5.1.jar
GlitchCore-neoforge-1.21.1-2.1.0.0.jar
HopoBetterRuinedPortals-[1.21.1-1.21.3]-1.4.4b.jar
HopoBetterUnderwaterRuins-[1.21.1-1.21.3]-1.2.1b.jar
irons_jewelry-1.21.1-1.4.0.jar
irons_rpg_tweaks-2.2.0.jar
irons_spellbooks-1.21.1-3.12.1.jar
irons_spells_js-4.0.2.jar
jei-1.21.1-neoforge-19.21.0.247.jar
kotlinforforge-5.8.0-all (1).jar
kubejs-neoforge-2101.7.1-build.181.jar
lithostitched-neoforge-1.21.1-1.4.5.jar
lootr-neoforge-1.21-1.10.35.91.jar
lukis-crazy-chambers-1.0.jar
medieval_buildings-1.21-1.1.0-neo.jar
memory_of_the_past-1.6.3-neoforge-1.21.1.jar
mods.txt
moonlight-1.21-2.18.13-neoforge.jar
Nullscape_1.21.x_v1.2.11.jar
oracle_index-neoforge-0.3.0.jar
owo-lib-neoforge-0.12.15.1-beta.3+1.21.jar
Pehkui-3.8.3+1.21-neoforge.jar
Philips-Ruins1.21.1-2.0-NeoForge.jar
Placebo-1.21.1-9.8.1.jar
player-animation-lib-forge-2.0.1+1.21.1.jar
prickle-neoforge-1.21.1-21.1.6.jar
ProbeJS-7.5.1.jar
rhino-2101.2.6-build.66.jar
Searchables-neoforge-1.21.1-1.0.2.jar
SereneSeasons-neoforge-1.21.1-10.1.0.3.jar
simplehats-neoforge-1.21.1-0.4.0 (1).jar
simplyswords-neoforge-1.60.11-1.21.1.jar
spyglass_improvements-1.5.7+mc1.21+neoforge.jar
Structory_1.21.x_v1.3.10.jar
SubtleEffects-neoforge-1.21.1-1.9.4-hotfix.1.jar
tectonic-neoforge-1.21.1-2.4.3.jar
wwoo-2.3.4.jar
YungsApi-1.21.1-NeoForge-5.1.5.jar
YungsBetterDesertTemples-1.21.1-NeoForge-4.1.5.jar
YungsBetterDungeons-1.21.1-NeoForge-5.1.4.jar
YungsBetterEndIsland-1.21.1-NeoForge-3.1.2.jar
YungsBetterJungleTemples-1.21.1-NeoForge-3.1.2.jar
YungsBetterMineshafts-1.21.1-NeoForge-5.1.1.jar
YungsBetterNetherFortresses-1.21.1-NeoForge-3.1.4.jar
YungsBetterOceanMonuments-1.21.1-NeoForge-4.1.2.jar
YungsBetterStrongholds-1.21.1-NeoForge-5.1.3.jar
YungsBetterWitchHuts-1.21.1-NeoForge-4.1.1.jar
YungsBridges-1.21.1-NeoForge-5.1.1.jar

Crashlog Check

• I understand if this is a crashbug and I did not attach a crashlog, this will not be handled

Fabric Check

• I understand if I am using Farbic APIs or Connector, this will not be handled

fixed in 3.12.2

Just confirming that this is working with the newest release. Thank you.