Iron's Spells 'n Spellbooks

Iron's Spells 'n Spellbooks

Mods
24M Downloads

[Bug] Priests exploding TPS on the latest version

Closed this issue · 4 comments

commented

Observed behaviour

Hello !
I am the author of the legendary edition modpack and people have been complaining to issues with priests AI being very TPS intensive for some reason.

Image

Here is a spark profile that shows the issue : https://spark.lucko.me/SbFVyfGtTx

Minecraft 1.20.1
irons_spellbooks-1.20.1-3.4.0.9.jar
Forge 47.4.0

Expected behaviour

Priests shouldn't lag the server (it happened at night but this is probably irrelevant)

Steps to reproduce

  1. Play on a server
  2. Spawn multiple priests in a village.
  3. Wait for them to attack mobs (not 100% repro though)

Server Type

Dedicated Server

Crashlog

No response

Iron's Spells N Spellbooks version

irons_spellbooks-1.20.1-3.4.0.9.jar

Forge version

Forge 47.4.0

Other mods

The entire Legendary Edition modpack : https://www.curseforge.com/minecraft/modpacks/minecraft-legendary-edition

Crashlog Check

  • I understand if this is a crashbug and I did not attach a crashlog, this will not be handled

Fabric Check

  • I understand if I am using Farbic APIs or Connector, this will not be handled
commented

This doesn't seem to be a priest issue, but a pathfinding issue. Try removing modernfix, or modernfix's managedBlock optimizations

commented

Hello. I don't have time right now to give a more minimal mod list, but I just ran into the same issue (long running scheduled tasks, if I'm reading the f3+2 graph right) and downgraded from irons_spellbooks-1.21.1-3.12.1 to irons_spellbooks-1.21.1-3.11.0 which seems to have solved the issue. I do not have modernfix installed at all.

This mod was not the cause of any of my problems, seemingly. Based on the spark profiler results, Sort It Out seems to have been my issue. It only manifested in multiplayer, so when I tested it alone I thought downgrading this mod fixed it. Sorry :(

commented

Hello! So just for the record : ModernFix wasn't the issue on our side, but going from Canary to Radium reforged + C2ME made it disappear for now, I'm not telling this is 100% fixed but so far we haven't got any issue on the priest tps since then

  • 👍1
commented

This issue was closed because it has been inactive for 14 days since being marked as stale.