Iron's Spells 'n Spellbooks

Iron's Spells 'n Spellbooks

24M Downloads

[Bug] Incompatibility with visual vibrance shader

Closed this issue ยท 6 comments

commented

Observed behaviour

The entity animations no longer work, they seem to be frozen. For your information, I tested with other shaders and did not reproduce the bug. I also tested with other mods using geckolib, and these mods worked perfectly with Visual Vibrance

Expected behaviour

They should keep the same animations as without the shader

Steps to reproduce

  1. Disable Visual Vibrance
  2. Create a world
  3. Spawn an apothecarist
  4. Enable Visual Vibrance
    => Animations are frozen

Server Type

Single Player

Crashlog

No response

Iron's Spells N Spellbooks version

1.21.1-3.12.1

Forge version

Neoforge 1.21.1 (21.1.179)

Other mods

Sodium, Iris shaders

Crashlog Check

  • I understand if this is a crashbug and I did not attach a crashlog, this will not be handled

Fabric Check

  • I understand if I am using Farbic APIs or Connector, this will not be handled
commented

luckily an issue with animation persistence during things like pausing the game is a bug that has been fixed. it seems this shader has a similar effect, just all the time

commented

Should this be fixed in version 3.12.3?

commented

no

commented

fixed in 3.13.0

commented

I reproduce it in 3.13.0

commented

this means visual vibrance is somehow extraneously triggering GeoModel#handleAnimations and bypassing the guard implemented in 3.13.0.

im no shader dev and it is unlikely i continue to look into this; you should create an issue with visual vibrance. they might have more insight