Isometric Renders

Isometric Renders

50.6k Downloads

Incompatibility with ModernFix mod

tunaflsh opened this issue · 7 comments

commented

When running /isorender area and waiting some time inside the GUI, game crashes.

latest.log
hs_err_pid58640.log

commented

seems broken still on 1.20.1. The 0.4.6 build will not load on my instance and complains about 1.20.2 being needed despite it showing 1.20.1 on CF
image

Maybe an oversight idk. Trying the modernfix config change now

commented

@gliscowo Does Isometric Renders do anything special with regards to freeing buffer builders? The crash appears to be caused by my buffer builder leak workaround

@tunaflsh Try setting mixin.bugfix.buffer_builder_leak=false in the ModernFix config and see if the crash is resolved.

commented

@‍gliscоwo Does Isometric Renders do anything special with regards to freeing buffer builders? The crash appears to be caused by my buffer builder leak workaround

https://github.com/gliscowo/worldmesher/blob/1.20/src/main/java/io/wispforest/worldmesher/WorldMesh.java#L395-L397

commented

This is problematic, as it does not set the buffer reference to null after freeing it, so my fix does not know to skip freeing the buffer itself.

commented

I've published a new WorldMesher build which clears the buffer reference - an update for Isometric should follow in the coming days

Cheers

commented

Thanks!

commented

Well that one sadly ended up taking a whole lot longer than I planned, but I finally got around to actually doing it. 0.4.6 now has the new WorldMesher version in it - which should fix the problem

Cheers