Item Stages

Item Stages

20M Downloads

Not everything gets hidden in JEI [1.16]

Diversion98 opened this issue ยท 7 comments

commented

Hi,

After restricting almost every mod that adds items behind a stage, some items will still show up in JEI.
I took some pictures of it, hope this helps u.

Cheers!

2021-08-22_17 14 36
2021-08-22_17 15 34
2021-08-22_17 18 30
2021-08-22_17 18 33

commented

I noticed this issue happen with the mod Modernxl. Additionally, only some of the items are still visible. And, when I remove stages, or do /gamestage clear, those items duplicate in JEI so it shows more and more of them.

commented

my items in JEI don't get duplicated though, just tested it

commented

Hello, thanks for the issue report. I can recreate your issue with Chisel and Bits but have not looked into the other mods yet. After debugging things it looks like it may be a bug with JEI or potentially each of those specific mods. I've already reached out to some of the mod authors and will work with them to solve this. The following notes are just to help me and the other devs keep track of things.

  1. Chisel is adding the block_bit variants via addIngredientsAtRuntime.
  2. ItemStages is grabbing all ItemStack being displayed using getAllIngredients(VanillaTypes.ITEM).
  3. Chisel's entries are being added to the list before stages gets the ingredients. log - 39
  4. When stages accesses the ingredient list only one block_bit exists. log - 1286
  5. After stages runs there are no block_bit in the ingredient list, but they still display. log - 2538
commented

Any news on this issue? :)

commented

Unfortunately I haven't heard anything back from the JEI team. I will reach out again.

commented

Allright no worries, was just curious :)
It's not that big of an issue ;)

commented

image
The mod born in chaos doesn't hide too.. im in 1.19.2 with the version 5.1.4.
Others items from others mods shows too.
In this version, chisels and bits doesn't show anymore. (they doesn't runtime anymore..)

maybe use this
https://github.com/mezz/JustEnoughItems/blob/1.20/CommonApi/src/main/java/mezz/jei/api/runtime/IIngredientManager.java#L78
to get runtime ingredients..