[1.12.2] Picking up sinking/floating items with right click causes next two right clicks to fail
Charles445 opened this issue · 2 comments
Tested wtih CreativeCore_v1.9.71_mc1.12.2 + ItemPhysic_Full_1.4.26_mc1.12.2
Right clicking to pick up an item that is floating or sinking will cause the next two right click block interactions to fail/desync. I've included a video to demonstrate this bug.
If it helps any, this effect is present in CreativeCore_v1.9.67_mc1.12.2 + ItemPhysic_Full_1.4.21_mc1.12.2, but it only causes one right click to fail in that version.
Okay, I think I've figured out what's going on.
The mod cancels right clicks to avoid interacting with blocks under your crosshair when picking up an item.
The problem is, if you were to pick up an item and you don't have a block under your crosshair, the player gets added to the toCancel array even though there is no right click event that needs cancelling.
So this bug also happens when you toss an item into the air and grab it with right click.
It can also cause multiple right clicks to fail if you keep doing it since the array just gets bigger.
