Jade Addons (Forge)

Jade Addons (Forge)

Mods
6M Downloads

Create contraption provider causes memory leak

embeddedt opened this issue ยท 0 comments

commented

Mod loader

Forge

Minecraft version

1.20.1

Mod version

5.1.0

Modloader version

47.1.62 (NeoForge)

Modpack info

ForgeCraft 1.20

If bug:

  • Can you reproduce this issue with relevant mods only?

If bug: The latest.log file

No response

Issue description

The ContraptionExactBlockProvider (and possibly other providers) appear to retain a reference to the client level and player even after exiting the world. This causes additional memory usage when joining a second world.

image

This could potentially be fixed in Jade itself by changing AccessorImpl to use WeakReferences, however any uses of the getLevel and getPlayer APIs would need to support the possibility of them returning null.