Jade πŸ”

Jade πŸ”

93M Downloads

Suggestion: entity names conditionally display

davidjjung opened this issue Β· 2 comments

commented

Mod loader

Forge

Minecraft version

1.19.2

Mod version

8.9.2

Modloader version

Forge 43.3.0

Modpack info

No response

[IMPORTANT] If bug:

  • I have confirmed this bug is reproducible on a minimal setup, not a modpack with many other mods.

[IMPORTANT] If bug: The latest.log file, not the crash report

No response

Issue description

I'd like to suggest that entities/players do not display their names/EntityType/username if Entity.shouldShowName()/Entity.isCustomNameVisible is false, or if (specifically for Forge) something like a hook into RenderNameTagEvent would return Event.Result.DENY.

The version isn't particularly important (assuming this feature hasn't been implemented in later versions, in that case whoops my bad haha). I was mostly asking to tackle this issue and perhaps others in one fell swoop via a sensible-enough feature suggestion. I did want to try mixin-ing before names are rendered in a separate workspace, but I haven't found the specific Jade method for showing the entity's username/entitytypeπŸ˜…. Thanks for your time

commented

The methods you mention only control how the name tag is rendered. It will still appear somewhere else. For Jade, you can replace the entity name with anything else in a plugin

commented

Just figured out how to do it (currently via a mixin to ObjectNameProvider's appendTooltip). thanks for the tip!