"Duplicate plugin class" crash on 18.0.1 with Quilt + 1.21.5
jbhannah opened this issue · 4 comments
Mod loader
Quilt
Minecraft version
1.21.5
Mod version
18.0.1
Modloader version
Quilt 0.28.0 / Fabric API 0.119.6+1.21.5
Modpack info
Empty instance with only Jade and Fabric API installed.
[IMPORTANT] If bug:
- I have confirmed this bug is reproducible on a minimal setup, not a modpack with many other mods.
[IMPORTANT] If bug: The latest.log file, not the crash report
Issue description
Also tested in Quilt 0.28.1-beta2 with the same issue. 18.0.0 does not crash, so this was introduced in 18.0.1. 18.0.1 does not crash with the latest Fabric loader version + same Fabric API version, so this is exclusive to Quilt.
I think this is Quilt's bug. EntrypointContainer always returns empty string: https://github.com/QuiltMC/quilt-loader/blob/e4e2256d1633b77a6cfc2773a568bd04d28b6ee4/src/main/java/org/quiltmc/loader/api/entrypoint/EntrypointContainer.java#L43
fabric appears to have the same behavior in EntrypointContainer: https://github.com/FabricMC/fabric-loader/blob/fda9a7b84f0898f57b46fbbfda58795e7fa31cef/src/main/java/net/fabricmc/loader/api/entrypoint/EntrypointContainer.java#L42
it does, however, look like quilt's implementation of getEntrypointContainers differs from fabric's, so it may be a bug in there
it does, however, look like quilt's implementation of getEntrypointContainers differs from fabric's, so it may be a bug in there
specifically, quilt may be returning duplicate entries for plugins. hope this helps, i may be able to clone the repo and take a deeper look at some point but might not be this week.