Just Enough Items (JEI)

Just Enough Items (JEI)

392M Downloads

Recipes not being display with newest version

SaphieNyako opened this issue · 16 comments

commented

version: jei-1.16.5-7.7.1.122.jar

Since the new update recipes are not being displayed of multiple mods.
Examples are:
feywild - dwarven anvil, altar
botania - elven trades, mana infusion
create - alot of recipes

commented

also broken are the ones for Draconic Evolution, Thermal, and Blood Magic

commented

Recipes from token enchanting are broken in 1.17.1 (37.0.82) with jei-1.17.1-8.1.0.21.

commented

The change:

private <T> void addRecipe(T recipe, RecipeCategoryData<T> recipeCategoryData) {
IRecipeCategory<T> recipeCategory = recipeCategoryData.getRecipeCategory();
if (!recipeCategory.isHandled(recipe)) {
return;
}

Which leads to here:
default boolean isHandled(T recipe) {
if (recipe instanceof IRecipe) {
IRecipe<?> iRecipe = (IRecipe<?>) recipe;
return !iRecipe.isSpecial();

The problem is that the majority of modders have set their custom recipe types to return true from isSpecial, because the recipe book emits a log message for every single recipe it does not known how to handle (see ClientRecipeBook#getCategory).

commented
  @Override
    default boolean isSpecial() {
        return false;
    }

Setting it false fixed it.
Thanks.

commented

Thanks for the report!
Hubry's assessment is correct.
This should be fixed in the next version.

commented

If your goal is just fixing this in your mod, overriding isHandled in your JEI category will fix this without the sideeffect of recipe book log spam.

commented

I had to go back to jei-1.16.5-7.7.1.119 before it worked correctly. Mekanism recipes were missing. I'm sure others as well.

commented

Please try with
jei-1.16.5-7.7.1.125

commented

Can confirm. Like Immersive Engineering's Coke Oven or multiblocks in general.
Cheers

commented

Can also confirm, this breaks Compact Crafting recipe display as well

commented

Please try with jei-1.16.5-7.7.1.125

There are still missing recipes in this version

commented

Can you please give specific information about which recipes are missing, and from which mods?

commented

Can you please give specific information about which recipes are missing, and from which mods?

Of the mods I use it's all non-vanilla methods from tinkers except for casting. As well as all non-vanilla methods from thermal expansion, mekanism, astral sorcery, botania, resourceful bees, mystical agriculture, and draconic evolution.

commented

Are you using the most recent version of Tinker's as well?
It seems related to this issue, which they marked as resolved with JEI's update: SlimeKnights/TinkersConstruct#4636

If you still get the issue with the latest JEI and Tinker's, please link a client log here and I can take a look.

commented

Are you using the most recent version of Tinker's as well? It seems related to this issue, which they marked as resolved with JEI's update: SlimeKnights/TinkersConstruct#4636

If you still get the issue with the latest JEI and Tinker's, please link a client log here and I can take a look.

Turns out I didn't have the right version of JEI

commented

Ok cool, thanks for confirming. Glad it’s fixed!