Stall on Joining World - Building ingredient filter...
itsdinkd opened this issue · 23 comments
Using JEI on my modpack for 1.18.1, with forge loader 39.0.8, All players joining a dedicated server get stuck on "Joining World"... for about 5-10 minutes. If they click or do anything during that time, the game will go unresponsive. In the logs, the last thing that its doing is
Building ingredient filter...
I have tried the second most recent version of JEI, with no dece, same issue. So then I tried using Roughly Enough Items instead of JEI, and the players were able to join at normal times/speeds.
Latest Log- https://pastebin.com/DkhV33db
I have implemented some memory performance improvements here: #2734
This is available in JEI 9.4.1.109
, can you try it out?
Just messaged you, sorry for delay. Adding JEI into my latest update, and on dedicated server for modpack.
Also with the latest version and new logging, I think these are the cause for the delay, idk. not too sure.
Log; https://gist.github.com/itsdinkd/f27076a14949db12d03428e93b508e77
Using the latest JEI that came out yesterday for 1.18.1
Thanks for the log! I've been working on making stuff like this easier to diagnose, and the new log should help a lot.
Starting JEI took 22.19 s
that's not very fast, but it's not a "Stall on Joining World for 5-10 minutes" like reported in the issue.
Have things really improved?
If someone is still stalling for a long time, I think their log with the latest JEI will really help us figure out what's going on here.
This may be related to another bug that was fixed (#2582), please try with the latest version and see how it goes.
@mezz was this addressed by chance in latest update? would love to switch my modpack back to JEI
So I finally had the time to test JEI with it's latest version. its not as long but its still taking quite some time, 1 minute and 30 seconds to be exact. but REI for some reason only takes 30-40 seconds.
in this log, it shows from start of connecting to server up to connected. https://gist.github.com/itsdinkd/625895d6c4edbed01f507101d65d9ee5
Actually after comparing both true times via logs from connecting to server, to connected, REI took 1 minute and 13 seconds, JEI took 1 minute and 33 seconds.
JEI tracks the time of various loading stages, you can see the total time at the end of the log: Starting JEI took 25.36 s
.
That includes all the plugins, checks, building steps, etc.
Digging in more detail is possible, but the Forge logs are configured poorly right now so you can't easily find all the logs coming from JEI.
As long as the stall is fixed I think this issue can be closed. Please open a new issue if you're concerned about the startup performance.
I'm not at all certain, but it appears to me that MinecraftForge/MinecraftForge#8359 relates to this as well.
Getting tons of reports that its happening ( I officially switched the pack back over to JEI ) and whats odd is its only happening to players who join a server for the first time.
My modpack is https://www.curseforge.com/minecraft/modpacks/another-quality-modpack-3 (if you'd like to test)
but it only happens when people join servers for the first time. when you are joining after you've been on it before (you get my experience of the whole 1:30 second load)
I also am using modloader 0.22 on the modpack, and in the server pack downloader for everyone to use so the .20 update did not do anything to fix this issue with JEI and first time join
Definitely possible! Looks like it's a good idea to update to the latest version of Forge to avoid that issue.
Thanks for the pack link, I'll try this out with a java profiler and try to see what's going on.
I was able to join the Zion server without any issues on my first try, is this still a problem for people?
I tried running this locally, with a brand-new server using the link on curseforge curseforge.com/minecraft/modpacks/another-quality-modpack-3
Created a new modpack instance on curseforge to have a fresh start.
I added the latest JEI, then disabled REI and RoughlyEnoughItems-jei-internals-workaround on both the client and server.
On first join, it took quite a long time to join but it did complete. I ran this with a java profiler attached in order to see what JEI was doing, and didn't find much out of the ordinary.
75 seconds was spent on loading JEI
ClientLifecycleHandler.java:107 mezz.jei.startup.ClientLifecycleHandler.setupJEI() 75197
- 39 seconds of that was from JER loading
CommonProxy.java:14 jeresources.compatibility.Compatibility.init() 39068
, maybe that could be improved. - 22 seconds was from JEI getting tooltip strings, which is about what's expected for a pack this large
- the remaining 14 seconds was spent by other plugins and by JEI doing all kinds of other stuff like finding all the vanilla items.
This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.