[Bug]: [1.19] Missing Client config on Mod menu
ffuentesm opened this issue · 20 comments
Steps to Reproduce the Bug
Install JEI in 1.19
Go to JEI mod menu config
Expected Behavior
There should be a client config in the mod menu to set the UI size and other settings.
Actual Behavior
There is no Ingame client config and requires a menu file config setting.
Mod Pack URL (Optional)
No response
Mod Pack Version (Optional)
No response
Extra Notes (Optional)
No response
latest.log
https://gist.github.com/ffuentesm/b76ee4cbe0d08c39610b1148e9c16d32
I think Botania would be a good example of strictly separating common ("XPlat") and loader-specific (Forge/Fabric) code, including the configuration. I believe their approach is internally defining an interface to access their configuration values, and then for each loader system they implement that interface with the platform-specific configuration system. For Forge that's Forge's configuration API, and for Fabric they appear to be using fiber.
Yes, agreed. This is marked as a bug accordingly.
Unfortunately there is no "Forge-specific API", it is a Forge-specific implementation. You must use their implementation to be compatible with mods that display the config menu. I am not sure how other mods are implementing their configs to be cross-platform but if you know of some then I can take a look for ideas.
Thanks for the report!
This is happening because I rewrote the configs to work on both Forge and Fabric.
This mod menu can only show Forge configs, so I need to find another way to make it display.
I have been seeing the same issue and from what I can tell it seems that the client config is being generated as a .ini file rather than a .toml file causing it to be inaccessible. I am no expert so I may be way off but that is my guess.
That seems suboptimal, considering the client (rather than server) config is the thing players care about most. Other mods are compatible with both Forge and Fabric, and still are able to expose their raw configuration through the Forge-specific API.
(Not exposing it to the API would only be reasonable if there was a custom in-game way to access it. You probably shouldn't require players to dig through the config folders.)
The issue is still here. We should be able to config how many columns and rows will show in-game! :(
Thanks for the report! This is happening because I rewrote the configs to work on both Forge and Fabric. This mod menu can only show Forge configs, so I need to find another way to make it display.
How about just making a simple if-else? Cant be that hard to check if its using fabric or forge. I mean you are already doing that no? Else you would have had 2 different versions and this would never have been a problem. And the server config still works as it should. So i fail to see what the issue could be.
On a similar note, it dosn't even find it even if you rename the file to .toml, so i cant even fix it on my side.
I'm going to bump this as well because I'm also having this exact same issue. It doesn't make you feel good when you see this issue has existed for well over a year & many tickets regarding the issue are automatically closed because you don't respond & the original posters don't bother coming back and opening them again.
Using Minecraft version 1.19.2, forge version 43.2.10
Can access server config just fine, but I don't care about that. I want the client config. That I can't access :/
Doesn't look like this was ever fixed, and this is causing issues for modpacks on older versions like 1.18.2.
This could be a suggested feature for Configured, to auto generate GUI config menus from .ini files?
If you are using fabric, look here: #3127 (comment)