Just Enough Items (JEI)

Just Enough Items (JEI)

387M Downloads

[Other]: IGhostIngredientHandler.Target doesn't used ITypedIngredient

shartte opened this issue ยท 2 comments

commented

Other

While IGhostIngredientHandler uses ITypedIngredient, Target:apply doesn't. This makes targets a bit awkward to use.

It would also be nice to document in mezz.jei.api.gui.handlers.IGhostIngredientHandler#getTargetsTyped whether the returned targets will only be used with the given ingredient. If that's the case, then plugins that create the targets on-the-fly could just capture the ingredient in the created targets, instead of using the ingredient passed to accept.

commented

This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

commented

This has been automatically closed because it has not had recent activity. Please feel free to update or reopen it.