Just Enough Items (JEI)

Just Enough Items (JEI)

387M Downloads

[Bug] [1.12] TippedArrowRecipeMaker does not check if the recipe exists, it always shows the recipe

Atricos opened this issue ยท 6 comments

commented

Steps to Reproduce the Bug

  1. Add JEI and CraftTweaker to your modpack.
  2. Remove the Tipped Arrow recipe with CraftTweaker, for example: recipes.removeAll(); or recipes.remove(<minecraft:tipped_arrow>); or recipes.removeByInput(<minecraft:arrow>);.
  3. Launch the game.
  4. Click on any Tipped Arrow: JEI still shows the recipe (seen below), even though their crafting recipes don't work (also see below).

Expected Behavior

JEI shouldn't show the recipe, since it does not exist anymore.

JEI doesn't actually check if the recipe exists:
image

Actual Behavior

JEI still shows the recipe:
image

Even though the recipe doesn't work:
image

Mod Pack URL (Optional)

No response

Mod Pack Version (Optional)

No response

Extra Notes (Optional)

I am using jei_1.12.2-4.16.1.301

latest.log

No response

commented

This should be easily fixable by just adding an if clause:
if (recipeExists) {addRecipe();} instead of just addRecipe();

commented

This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

commented

This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

The issue still persists, so it should remain open.

commented

Thanks for the report!
This issue has been fixed in later versions of JEI but the fix hasn't been backported yet. I can fix this for 1.12 soon

commented

This should be fixed in jei_1.12.2 version 4.16.1.1004

commented

This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.