[Bug] [1.12] TippedArrowRecipeMaker does not check if the recipe exists, it always shows the recipe
Atricos opened this issue ยท 6 comments
Steps to Reproduce the Bug
- Add JEI and CraftTweaker to your modpack.
- Remove the Tipped Arrow recipe with CraftTweaker, for example:
recipes.removeAll();
orrecipes.remove(<minecraft:tipped_arrow>);
orrecipes.removeByInput(<minecraft:arrow>);
. - Launch the game.
- Click on any Tipped Arrow: JEI still shows the recipe (seen below), even though their crafting recipes don't work (also see below).
Expected Behavior
JEI shouldn't show the recipe, since it does not exist anymore.
JEI doesn't actually check if the recipe exists:
Actual Behavior
Even though the recipe doesn't work:
Mod Pack URL (Optional)
No response
Mod Pack Version (Optional)
No response
Extra Notes (Optional)
I am using jei_1.12.2-4.16.1.301
latest.log
No response
This should be easily fixable by just adding an if clause:
if (recipeExists) {addRecipe();}
instead of just addRecipe();
This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.
This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.
The issue still persists, so it should remain open.
Thanks for the report!
This issue has been fixed in later versions of JEI but the fix hasn't been backported yet. I can fix this for 1.12 soon
This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.