[Crash]: [1.16.5] Random ConcurrentModificationException with JeiSpriteUploader whilst modpack is stitching textures
Kaleidio opened this issue ยท 2 comments
Steps to Reproduce the Crash
- Install Kaleidio's Battle Pack 5.4.0
- Cycle loading and closing over and over until this specific crash occurs (there is another start up crash but ignore that one as it is not related.)
Mod Pack URL (Optional)
https://legacy.curseforge.com/minecraft/modpacks/kaleidios-battle-pack
Mod Pack Version (Optional)
5.4.0
Extra Notes (Optional)
The crash is ridiculously random. It will crash most often if the window has no focus whilst the game is loading up. Quickly click off the window the moment it appears to try and force it.
The crash blames a vanilla foreach while stitch textures looking at this texture provider your code has
https://github.com/mezz/JustEnoughItems/blob/1.16/src/main/java/mezz/jei/gui/textures/JeiSpriteUploader.java
It seems, at least to my deduction, that your code for whatever reason does not guarantee through thread racing that the textures will be provided in time to the vanilla stitching system. However this is usually fine (especially without this modpack) unless the atlas is unusually heavy in count of items such as in my modpack, or some mods may not have finished stitching their own items yet or something along those lines.
Crash Report
https://gist.github.com/Kaleidio/2450d7cc2a0c4d899f74088e1f1c6ad2
This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.