Just Enough Items (JEI)

Other

JustEnoughItems/Common/src/test/java/mezz/jei/test/DeduplicatingRunnerTest.java

Lines 15 to 27 in 404514a

    
           @Test 
        
           public void testDeduplicatedRuns() throws InterruptedException { 
        
           	AtomicInteger runs = new AtomicInteger(); 
        
           	Runnable testRunnable = runs::getAndIncrement; 
        
           	Duration delay = Duration.ofMillis(10); 
        
           	DeduplicatingRunner deduplicatingRunner = new DeduplicatingRunner(testRunnable, delay, "test"); 
        
           	for (int i = 0; i < 10; i++) { 
        
           		deduplicatingRunner.run(); 
        
           	} 
        
           	Assertions.assertEquals(0, runs.get()); 
        
           	Thread.sleep(2 * delay.toMillis()); 
        
           	Assertions.assertEquals(1, runs.get()); 
        
           }

I guess it happens because on my computer, due to lags when I run :Common:test Gradle task, Thread.sleep ends faster than deduplicatingRunner's actions.
As a hotfix, I increased sleep delay to 5 * delay.toMillis().

To correctly fix it one should not use Thread.sleep at all, or, given enough lags, it will break again.
I think DeduplicatingRunnerTest.testSpacedOutRuns can have the same problem too.

	@Test
	public void testDeduplicatedRuns() throws InterruptedException {
	AtomicInteger runs = new AtomicInteger();
	Runnable testRunnable = runs::getAndIncrement;
	Duration delay = Duration.ofMillis(10);
	DeduplicatingRunner deduplicatingRunner = new DeduplicatingRunner(testRunnable, delay, "test");
	for (int i = 0; i < 10; i++) {
	deduplicatingRunner.run();
	}
	Assertions.assertEquals(0, runs.get());
	Thread.sleep(2 * delay.toMillis());
	Assertions.assertEquals(1, runs.get());
	}

Share to

Other