Just Enough Items (JEI)

Just Enough Items (JEI)

369M Downloads

[Bug]: As of JEI 15.8.x for Forge, `RenderTooltipEvent.GatherComponents` is no longer fired

squeek502 opened this issue · 9 comments

commented

Steps to Reproduce the Bug

AppleSkin tooltips are no longer rendered in the JEI side pane when hovering over food items.

Expected Behavior

In 15.4.x and before, RenderTooltipEvent.GatherComponents was fired and AppleSkin's FoodTooltipRenderer.renderImage was called from here:

Actual Behavior

In 15.8.x, guiGraphics.renderTooltipInternal is called instead, which bypasses the RenderTooltipEvent.GatherComponents call:

guiGraphics.renderTooltipInternal(font, components, x, y, DefaultTooltipPositioner.INSTANCE);

Extra Notes

Unsure if not firing RenderTooltipEvent.GatherComponents is intentional. Let me know if there's a different intended method of providing tooltip components to JEI.

Relevant AppleSkin issue: squeek502/AppleSkin#314

commented

I need a open a bunch of PRs with Forge and NeoForge to get this properly supported, please bear with me lol

Starting with 1.20.1 Forge here:

commented

1.21 NeoForge:

commented

Thanks for the report!
We made some changes in order to add fancy extra info to tooltips, I'll look into how I can restore support for this event.

commented

Appreciate the quick fix. Tested Forge/1.20.1 and NeoForge/1.21 and everything looks good.

commented

I have pushed a fix for this in 1.21, using the new NeoForge changes that were merged.

Forge changes haven't been merged yet, so I just wrote a hacky workaround for now in 1.20.1 and 1.21.
Please try it out (15.8.0.17+) and let me know if you see any more issues!

commented

Nice, thanks for confirming!
I'll leave this open until Forge merges my changes and I can get the "proper" fixes in.