Just Enough Items (JEI)

Just Enough Items (JEI)

Mods
464M Downloads

[Bug]: JEI does not use ClientTooltipFlag in NeoForge, causing modded item tooltip not able to fetch key flags

Closed this issue ยท 1 comments

commented

Steps to Reproduce the Bug

Line of question:

JustEnoughItems/Common/src/main/java/mezz/jei/common/util/SafeIngredientUtil.java

Line 40 in 389499b

TooltipFlag.Default tooltipFlag = minecraft.options.advancedItemTooltips ? TooltipFlag.Default.ADVANCED : TooltipFlag.Default.NORMAL;

Here JEI use TooltipFlag.Default

However, NeoForge provided ClientTooltipFlag API to allow mods safely accessing keys without using client-only classes and methods. Mods that use this feature will not be able to fetch key states from JEI

Expected Behavior

JEI should wrap their tooltip flag with ClientTooltipFlag.of when it's on NeoForge to ensure compatibility

Actual Behavior

currently TooltipFlag.hasShiftDown always return false in JEI tooltip

Mod Pack URL (Optional)

No response

Mod Pack Version (Optional)

No response

Extra Notes (Optional)

No response

latest.log

No response

commented

Thanks for the report!

I'm looking at the NeoForge PR here:

JEI only uses this call on the client-side so there is no problem there, but the lack of access to modifier keys isn't great. I'll look into a fix.