Custom biome support needed for some mods

Question

Custom biome support needed for some mods

Sunconure11 opened this issue 6 years ago · 12 comments

Sunconure11 · Answer 1 · 2018-06-22T03:00:52.000Z

While testing against Terra, I found this issue with BoP, when teleporting to a green beach.

https://paste.dimdev.org/arowuyesut.mccrash

Runemoro · Answer 2 · 2018-06-22T03:16:04.000Z

Twilight Forest, Thaumcraft, Abyssialcraft will all need support for biome update packets. What this means is that their worldgen will work correctly, but biome changing tools/spells/features will not resync the client until leaving and re-entering the world. So grass/leaves/sky colors might not update, but other than that, everything should work properly.

Creeping Nether will work, but the biome will not change at all (neither server nor client side).

I will be adding support for all of these mods in the next few days.

I'm not sure why the crash with BoP happened, but I saw it while testing in dev with just BoP a while ago, and haven't been able to reproduce it. I'll ask in the BoP discord to see if they might know what's wrong.

Runemoro · Answer 3 · 2018-06-22T03:38:52.000Z

Lost Cities isn't supported, see #4

Sunconure11 · Answer 4 · 2018-06-26T17:17:52.000Z

Encountered the same BoP crash without JEID.

https://pastebin.com/AHBKExq1

Sunconure11 · Answer 5 · 2018-06-26T17:19:42.000Z

When I managed to locate a wasteland, the biome completely changed into a tundra. WTF?

Sunconure11 · Answer 6 · 2018-06-26T17:30:29.000Z

Glitchfiend/BiomesOPlenty#1284

jredfox · Answer 7 · 2018-07-30T06:20:24.000Z

again why hard coded support just make a dynamic biome system that has extended ids this isn't acceptable to have hard coded support meaning any new or mods not in the hard coded list will glitch out the mod

Runemoro · Answer 8 · 2018-07-30T06:22:41.000Z

@jredfox Because it isn't possible to make a system that supports all mods... Each mod assumes that biome IDs are bytes in a different way.

Sunconure11 · Answer 9 · 2018-07-30T06:53:22.000Z

For safe measure, test against Novam Terra.

jredfox · Answer 10 · 2018-07-30T07:23:08.000Z

does not biome have an integer id via object and resource location? if so then it's up to the mods to fix it with your mod.

tell them to use forge not hard code stuff
public static int getIdForBiome(Biome biome) { return REGISTRY.getIDForObject(biome); }

is it the chunk that's causing the issue if so patch the chunk class to return int or something?

Runemoro · Answer 11 · 2018-07-30T07:29:56.000Z

No, biomes don't have integer IDs or resource locations. Adding support for other mods is easier and faster than getting them to support int biome IDs (and would also require them to add JEID as a dependency).

jredfox · Answer 12 · 2018-07-30T07:34:04.000Z

well there needs to be some sort of established interface to communicate between the biome id and biome.

so is every biome incompatible? if so I would say biomes cannot be extended without using your api at all and ids should start above the max value. Also I would make a forge pull request for extending something like this that breaks other mods

So basically
Hard coded list of supported mods:[] > your mappings
Everything that uses your api > your mappings
Everything else do nothing let ids be a byte

Now I could be totally misunderstanding how mods are getting the biome id but, I could be wrong. Elix_X has done this in the past and actually got it working with mods as long as they used his api if the ids were over 255

What does a biome do to the server side anyways besides chunks? Could you just say this biome is this in this array and then on client side override what the client thinks the biome should be and call it quits? If there is nothing besides the chunk which you patch then I would go with this approach.

Share to