JustEnoughIDs

JustEnoughIDs

13M Downloads

Possible conflict with newer builds of the twilight forest

Sunconure11 opened this issue ยท 18 comments

commented

This is caused by a change to BlockTFMagicLogSpecial#sendChangedBiome()
The method now accepts an additional Biome parameter and because of this, the mixin library crashes with an InvalidMixinException. This sounds like an easy fix but I'm not sure if there is more that needs to be done. The sendChangedBiome method also changed slighly since it now passes pos.getY() instead of 128.0 around.
TeamTwilight/twilightforest@a8c4575#diff-3726bc9a77a4b68c44c0c3bdeb7cd63eR159

commented

@Runemoro Any updated on if this or other JustEnoughIDs issues are being fixed or worked on

commented

I also have this issue, what is the latest version of The Twilight Forest that supports this?

Edit:
It is 3.8.689.

commented

Under what circumstance does this crash occur? I tried the newest TF+JEID in single player and it seems to be working just fine??

commented

@viceroy369 are you sure you used the latest versions of both? Twilight Forest 3.8.689 does indeed work, but it's not the latest version.
Installing the minimal setup with the following versions will crash on startup:

  • JustEnoughIDs-1.0.2-26
  • twilightforest-1.12.2-3.9.851-universal
    • CTM-MC1.12.2-0.3.3.22
    • Patchouli-1.0-17

It even crashes if you remove twilight forests dependencies (I assume the crash happens before forge could check the dependencies)

[12:48:03] [Client thread/FATAL]: Mixin apply failed mixins.jeid.modsupport.json:MixinBlockTFMagicLogSpecial -> twilightforest.block.BlockTFMagicLogSpecial: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException Overwrite target "sendChangedBiome" was not located in target class twilightforest/block/BlockTFMagicLogSpecial
org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: Overwrite target "sendChangedBiome" was not located in target class twilightforest/block/BlockTFMagicLogSpecial
commented

Derp. Hadn't notice TF had a new build out. Yes the latest version crashes.

commented

same here if use latest version TF is crashes but release version works fine

commented

any update on this one?

commented

There's an add on for JEID that fixes this

commented

huh okay where?? Is there any addon too for fixing broken biomes names? It was a long time since this has been updated and I can't just remove it...

Edit: found it

commented

Fixed in latest commits.

commented

any chance on a new cf build for this soon? last cf build was like october of last year.

commented

You could just use the GH release:
https://github.com/DimensionalDevelopment/JustEnoughIDs/releases

BUT those seem to not work for me. I still have to use JEID (old ver) + that JEID addon to fix this.

commented

whats the jeid addon that uses it? and no cant release a pack on twitch with unsupported builds (on cf), well you can but you gotta go through the 3rd party permission system which is a pita

commented

@DeadSix27 are you sure you're even using the latest release for the JEID dev builds? Cause JEIDsI won't do anything since those fixes were combined with ours with the permission of the dev who wrote the addon

commented

@ZombieHDGaming Yes, I've even build it myself from git master to make sure, doesn't work still.

EDIT: Here's a log, not sure if this was the correst test.. if it doesn't help ill make a new log, just say so: https://gist.github.com/DeadSix27/66d608bd3df60c7dd73787e8c1193c63 Note: See JEID being a snapshot build, that was the self build one,

EDIT2: Found one that used build31 from GH: https://gist.github.com/DeadSix27/1e361f017f969e48851bed9042a9117f

commented

Once the dev build is done building, give that a try. It should work perfectly now from my tests.