Expand potion and enchantment IDs

Question

Expand potion and enchantment IDs

Sunconure11 opened this issue 6 years ago · 6 comments

Sunconure11 commented 6 years ago

Unless those were taken care of, I don't see any code relating to them.

PulseBeat02 · Answer 1 · 2018-07-26T01:43:34.000Z

I also would like this enchancement.

Sunconure11 · Answer 2 · 2018-07-30T06:51:30.000Z

Wait, I remember discussing packets regarding a different mod in the past. Is it possible to extend the type of packet it is calling for in this error?

https://user-images.githubusercontent.com/5614902/42818207-3cc93d1e-899e-11e8-9f13-0f9fa3a14d6b.png

The mod causing this one in question is Howling Moon. I was never able to find the cause, and sort of gave up.

PulseBeat02 · Answer 3 · 2018-07-30T02:26:09.000Z

Sadly it is actually not possible to extend potion ID's (I just found out) SPacketEntityEffect sends the ID as a byte, allowing only 256 ID's available.

Runemoro · Answer 4 · 2018-07-30T02:50:34.000Z

That's not a problem. JEID will modify the packet to send it as an int. JEID already does the same for chunk update packets since vanilla Minecraft sends biome IDs as bytes too.

0Navis0 · Answer 5 · 2018-09-24T06:54:05.000Z

It would be awesome if all the new code features and fixes of 1.13 could be included in JEID and VanillaFix.

ZombieHDGaming · Answer 6 · 2018-10-07T21:38:41.000Z

Fucking finally done. Both will be released in the next release which is being reviewed atm.

Share to