[Performance]: FTB Chunks overlay causes huge loss of fps
kristi71111 opened this issue · 9 comments
Version:
journeymap-neoforge-1.21.1-6.0.0-beta.34
jmi-neoforge-1.21.1-1.6
Issue:
Having a lot of claims on a multiplayer server causes a huge loss of fps when FTB chunks overlay is enabled.
Alongside this toggling the setting off does not persist restarts.
As JMI is the mod that implements this I am reporting here.
related to #27 (comment)
Here's a new public build
https://modrinth.com/mod/journeymap-integration/version/1.21.1-1.7+neoforge
I'll keep this issue open until I get it stable
@kristi71111 Hi, could you try this build and check for any performance improvements?
If you're willing to run the Spark profiler as well, it would be helpful. Thank you!
jmi-neoforge-1.21.1-1.6.2.zip i got something wrong on this one, I'll upload a new build after i get it right
You'll need to rename this zip file to a jar file for it to load properly, and please note that it's still very buggy, just making sure I'm on the right track
This build should fix the issue above
This build should fix the issue above
Just tested. Did have some issues with it even rendering stuff however it eventually did show every claim up correctly and did not cause any noticeable fps drop so compared to before this is 100% an improvement.
Here's a short spark I did: Click me
I did manage to make it crash my client when someone unclaimed a chunk. Crash: Click me
Sounds great!
Just tested. Did have some issues with it even rendering stuff...
Could you describe more about these?
Sounds great!
Just tested. Did have some issues with it even rendering stuff...
Could you describe more about these?
It might be that the client took so long to actually process all of the packets received for the claims from the server. Or it might have been the toogle button again (I might recommend making it more visual when it's in a on/off state. But like I said it did eventually show everything at once.
Here's a new public build https://modrinth.com/mod/journeymap-integration/version/1.21.1-1.7+neoforge
I'll keep this issue open until I get it stable
New crash for you.
Click here
New crash for you. Click here
https://modrinth.com/mod/journeymap-integration/version/1.21.1-1.7.1+neoforge
I can't reproduce this in my dev environment so I'm not sure if this build create new issue like not sync the claimed chunk data properly or what
And I made some changes to improve the rendering process when logging into a world, but I don't have a test environment with enough claimed chunks to notice much difference. It would be great to hear your feedback about this after trying this build.