Just Enough Calculation

Just Enough Calculation

11M Downloads

Crash when saving an empty recipe

KindarConrath opened this issue · 10 comments

commented

I'll create a more detailed report later, but I crashed my game when I edited a recipe, deleted everything and hit save.

commented

Thanks for report!

No need for further testing. I have already had it reproduced.

commented

+1 crash with the same issue, Save button was not disabled.

https://pastebin.com/mLm7We4n

commented

@ClockwiseGear Thanks! Got it.

commented

Hi @ClockwiseGear

Can you provide some steps to reproduce the issue?

commented
commented
commented

Should be fixed for both 1.12 and 1.14 latest version

commented

This has just happened to me as well. If bdd66e7 is included in the most recent version of JEC on Curse, the issue appears to be unresolved.

I had populated a recipe with the JEI + button, realised that it had cycled to the next recipe, then started to remove the items from the grid. After clearing the last item from the recipe, I (accidentally) clicked the Save button. The game then froze for a few seconds and exited with the following message:

The game crashed whilst updating screen events
Error: java.lang.IllegalArgumentException: Invalid recipe

Full crash report: crash-2019-06-25_01.32.02-client.txt

commented

Thanks for report!

The fix should have been pushed to curse. To clarify, this crash happens when the player attempts to save a recipe with empty input or output list. The "save" button should be disabled when any of them is empty to prevent such behavior. So can you further describe steps to reproduce it?

commented

The Save button was not disabled (but it might have been greyed out), hence the crash.
I can't remember exactly what I did, but I think that this may have happened on a recipe that had already been saved, i.e. the crash happened when editing the existing recipe.