Just Enough Effect Descriptions (JEED)

Just Enough Effect Descriptions (JEED)

16M Downloads

[1.20.1] Clicking on effect causing crash if no JEI/REI/EMI installed

Snownee opened this issue ยท 8 comments

commented
java.lang.NullPointerException: Cannot invoke "net.mehvahdjukaar.jeed.common.IPlugin.onClickedEffect(net.minecraft.world.effect.MobEffectInstance, double, double, int)" because "net.mehvahdjukaar.jeed.Jeed.PLUGIN" is null

Also I would suggest an API to detemine if an effect is clickable, and an API to click on the effect.

commented

uhm well the mod is not meant to be used without either JEI,EMI or REI as its an addon. thing is it should crash at the beginning under this circumstance. I can add a tag for clickable effect. what is the use case for clickable callbacks?

commented

So what kind of hooks do you need?

commented

I think it would be ideal if this could be implemented in Jeed's API package

commented

yes

commented

so I'm a bit confused by that. I checke and it seems i aleady have a tag. For the click stuff however I am not sure what i sould add. The Jeed.PLUGIN.onClickedEffect call already exist. i guess i can move that to a delegating method in the JeedAPI class, something like invokeEffectClicked. Is that what you would want? So I'm assuming you would just need both the tag and that call to be put in JeedAPI?

commented

done, at least in 1.21 for now

commented

thank you! ๐Ÿ™