Just Enough Resources (JER)

Just Enough Resources (JER)

163M Downloads

1.16.5 incompatibility with JER and Feywild

SaphieNyako opened this issue ยท 7 comments

commented

When Feywild is installed with JER loot table recipes tabs of JER aren't shown anymore.

1.16.5
Feywild - 1.16.5 - 2.1.2
Forge 36.2.31

commented

Anything we can work with?

commented

issue seems be in JEI loading, can you make sure no JEI interaction is present in Feywild when testing?

java.util.ConcurrentModificationException
	at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
	at java.util.ArrayList$Itr.next(ArrayList.java:851)
	at mezz.jei.load.PluginCaller.callOnPlugins(PluginCaller.java:21)
	at mezz.jei.load.PluginLoader.<init>(PluginLoader.java:109)
	at mezz.jei.startup.JeiStarter.start(JeiStarter.java:69)
	at mezz.jei.startup.ClientLifecycleHandler.startJEI(ClientLifecycleHandler.java:147)
	at mezz.jei.startup.ClientLifecycleHandler.setupJEI(ClientLifecycleHandler.java:140)
	at mezz.jei.startup.ClientLifecycleHandler.lambda$new$3(ClientLifecycleHandler.java:106)
	at mezz.jei.startup.ClientLifecycleHandler$$Lambda$4380/1974708900.accept(Unknown Source)
commented

It's not our JEI plugin, I disabled that completely and it still happens.
Its not our way of adding to loot tables, disabled that too and it still happens.
I can't find any events that could disturb theirs.
I tried compair with other mods but we arent doing anything different.

commented

Could you post a full (client) log? Something must be going wrong and should be spit out there :)

commented
commented

I found the cause of the problem:
https://github.com/SaphieNyako/Feywild/blob/80ba1c3bf1cd4adf2db4b994fafe184d048d08d7/src/main/java/com/feywild/feywild/network/TradesHandler.java#L15

If I remove the reload everything seems to work fine...
Though if changes are made to a datapack it might cause problems.

I'll make a update for feywild 1.16, also will change it in the 1.18 version.

commented