JustHammers

JustHammers

8M Downloads

[Issue] JustHammers passing an immutable list to the `BlockDropsEvent` breaks game

Closed this issue ยท 1 comments

commented

Minecraft Version

1.21.1

Modloader

NeoForge

Mod version

21.1.0

Latest version?

  • Yes

Repeatable?

  • Yes

Link to log files

https://mclo.gs/3J37uIB

Steps to reproduce the issue

[ covered below ]

Description of the issue you are having

Hello.

On Craftoria's public servers, we've found the combo of Just Hammers + Ultimine +
Apotheosis' Boon of the Earth will stop anything from dropping anymore, from any source, for everyone, until server reset.

Combining just two of those three:

  • Ultimine + Just Hammers works "fine" without Boon
  • Just Hammers + Boon fails to mine at all, and spits out errors

(Boon + Ultimine works as it should)

Apotheosis dev was consulted first, and they pointed out that, to quote:

That's on hammers; they're passing an immutable list to the BlockDropsEvent
Whereas the contract of BlockDropsEvent#getDrops() is Returns a mutable list of item entities that will be dropped by this block.

https://discord.com/channels/570630340075454474/821417666332983306/1401010119852167249

Thanks for JH!; hope this can get addressed soon.

Information

  • I have provided as much information as possible
commented

Fixed as of 8971473 and 38f7b05

Nice catch, please let me know if this doesn't resolve the issue