KubeJS (Old)

KubeJS (Old)

3M Downloads

Villager Trades support

Martmists-GH opened this issue ยท 6 comments

commented

Please add support for removing/adding trades from the wandering trader.

commented

That architectury issue is closed. Are there any plans to include this in KubeJS?

commented

@MaxNeedsSnacks Architectury issues architectury/architectury-api#70, architectury/architectury-api#84, and architectury/architectury-api#86 pertained to the villager trades - which are all closed.

Do we want to keep this open, and does this need to be marked Forge Specific?

commented

This has been implemented in AlmostReliable's MoreJS (on 1.18 and 1.19), and because we don't want to reinvent the wheel here, it likely won't be part of KubeJS itself anytime soon, so I'm going to be closing this for now ^^

commented

It would be great for villager trades in general ๐Ÿ˜„ Afaik KubeJS Fabric has already this feature ๐Ÿ˜ญ

Cheers ๐Ÿบ

commented

I'd like to wait for architectury/architectury-api#86 before implementing this, since the Architectury API structure may still change until then, but @lythowastaken has actually started work on that, so we may be good to go on this soon

commented

This needs a new feature in architectury, the issue for which can be tracked here: architectury/architectury-api#70

For anyone wanting to help out, feel free to add your thoughts there ^^