KubeJS (Old)

KubeJS (Old)

3M Downloads

[1.18.2/1.19.2] Fluid vaporization

cech12 opened this issue ยท 0 comments

commented

Minecraft Version

1.18.2 & 1.19.2

KubeJS Version

1802.5.5-build.569 & 1902.6.0-build.142

Rhino Version

1802.2.1-build.252 & 1902.2.2-build.264

Architectury Version

v4.11.89 & v6.5.69

Forge/Fabric Version

Forge 40.2.8 & 43.2.6

Describe your issue

Hey,

I am the developer of the BucketLib mod and I got a bug report about the vaporization behaviour of fluids which are generated by KubeJS: cech12/WoodenBucket#7

This was caused by an inconsistency between the tool functions of Forge and the vanilla BucketItem implementation. It was already fixed in Forge for 1.19.3 by calling the tool function in the vanilla BucketItem: MinecraftForge/MinecraftForge#9269

These changes were backported to 1.18.2 and 1.19.2:

I expect that this will cause that all fluids which are generated with KubeJS will vaporize in the Nether.

There are multiple ways to fix that:

  • don't use the Material.WATER for the fluids
  • override the doesVaporize (1.18.2) or isVaporizedOnPlacement (1.19.2) method of the FluidAttributes/FluidType of the fluids
  • make a configuration option for fluids which defines if the fluid should vaporize in the Nether or not

Crash report/logs

No response