KubeJS TFC

KubeJS TFC

476k Downloads

`event.simpleBlockState` is not work

Closed this issue ยท 3 comments

commented

I tried this script:

TFCEvents.worldgenData(event => {
    event.simpleBlockState('example_crop_placement', 'minecraft:oak_log[axis=x]', placement => {
        placement.heightMap('world_surface_wg')
    })
})
ServerEvents.tags('worldgen/placed_features', event => {
    event.add('tfc:feature/crops', 'kubejs_tfc:example_crop_placement')
})

An error doesn't occured, and it didn't worked.
I think, it should add kubejs_tfc:example_crop_placement in local/kubejs/export/tags/minecraft/worldgen/placed_feature/tfc/feature/crops.json, but i couldn't find.

I checked that some other registration event (geodes, boulders) is working.

commented

did you check in local/kubejs/export/tags/tfc/worldgen/placed_feature/feature/crops.json? that's where it should be unless kube is doing something really janky with the export

commented

Again, I tried this server script:

TFCEvents.worldgenData(event => {
  event.simpleBlockState('example_crop_placement', 'minecraft:oak_log[axis=x]', placement => {
      placement.heightMap('world_surface_wg')
  })
})
ServerEvents.tags('worldgen/placed_features', event => {
  event.add('tfc:feature/crops', 'kubejs_tfc:example_crop_placement')
})

TFCEvents.worldgenData(event => {
  event.geode('example_geode', 'minecraft:oak_log[axis=x]', 'tfc:rock/hardened/basalt', ['6 tfc:rock/raw/quartzite', 'minecraft:cut_copper'], placement => {
      placement.tfcBiome()
      placement.inSquare()
      placement.jsonPlacement({
          type: 'minecraft:height_range',
          height: {
              type: 'uniform',
              min_inclusive: {
                  absolute: -48
              },
              max_inclusive: {
                  absolute: 32
              }
          }
      })
  })
})
ServerEvents.tags('worldgen/placed_feature', event => {
  event.add('tfc:in_biome/veins', 'kubejs_tfc:example_geode')
})

kubejs_tfc:example_geode is found in local\kubejs\export\tags\minecraft\worldgen\placed_feature\tfc\in_biome\veins.json .
but kubejs_tfc:example_crop_placement is not found in local\kubejs\export\tags\minecraft\worldgen\placed_feature\tfc\feature\crops.json.
could you check in your environment?

I think this registration has some problem about genrating json (so this registration is ignored), I also confirmed when script doesn't has block property, it causes crash in world data creation.

crash script example:

TFCEvents.worldgenData(event => {
  event.simpleBlockState('example_crop_placement', 'minecraft:oak_log', placement => {
      placement.heightMap('world_surface_wg')
  })
})
ServerEvents.tags('worldgen/placed_features', event => {
  event.add('tfc:feature/crops', 'kubejs_tfc:example_crop_placement')
})
error log
> Errors in registry minecraft:root:
>> Errors in element minecraft:worldgen/configured_feature:
java.lang.IllegalStateException: Unbound values in registry ResourceKey[minecraft:root / minecraft:worldgen/configured_feature]: [kubejs_tfc:example_crop_placement]
	at TRANSFORMER/[email protected]/net.minecraft.core.MappedRegistry.m_203521_(MappedRegistry.java:331)
	at TRANSFORMER/[email protected]/net.minecraft.resources.RegistryDataLoader.m_257131_(RegistryDataLoader.java:69)
	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
	at TRANSFORMER/[email protected]/net.minecraft.resources.RegistryDataLoader.m_247207_(RegistryDataLoader.java:65)
	at TRANSFORMER/[email protected]/net.minecraft.server.WorldLoader.m_246152_(WorldLoader.java:54)
	at TRANSFORMER/[email protected]/net.minecraft.server.WorldLoader.m_245736_(WorldLoader.java:58)
	at TRANSFORMER/[email protected]/net.minecraft.server.WorldLoader.m_214362_(WorldLoader.java:31)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.worldselection.CreateWorldScreen.m_232896_(CreateWorldScreen.java:125)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.worldselection.SelectWorldScreen.m_279861_(SelectWorldScreen.java:60)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.components.Button.m_5691_(Button.java:38)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.components.AbstractButton.m_5716_(AbstractButton.java:55)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.components.AbstractWidget.m_6375_(AbstractWidget.java:175)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.components.events.ContainerEventHandler.m_6375_(ContainerEventHandler.java:38)
	at TRANSFORMER/[email protected]/net.minecraft.client.MouseHandler.m_168084_(MouseHandler.java:92)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.Screen.m_96579_(Screen.java:437)
	at TRANSFORMER/[email protected]/net.minecraft.client.MouseHandler.m_91530_(MouseHandler.java:89)
	at TRANSFORMER/[email protected]/net.minecraft.client.MouseHandler.m_168091_(MouseHandler.java:189)
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.execute(BlockableEventLoop.java:102)
	at TRANSFORMER/[email protected]/net.minecraft.client.MouseHandler.m_91565_(MouseHandler.java:188)
	at MC-BOOTSTRAP/[email protected]+7/org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
	at MC-BOOTSTRAP/[email protected]+7/org.lwjgl.system.JNI.invokeV(Native Method)
	at MC-BOOTSTRAP/[email protected]+7/org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474)
	at TRANSFORMER/[email protected]/com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237)
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1173)
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718)
	at TRANSFORMER/[email protected]/net.minecraft.client.main.Main.main(Main.java:218)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111)
	at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99)
	at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:108)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:78)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141)
> Errors in registry minecraft:worldgen/configured_feature:
>> Errors in element kubejs_tfc:example_crop_placement:
java.lang.IllegalStateException: Failed to parse kubejs_tfc:worldgen/configured_feature/example_crop_placement.json from pack KubeJS Virtual Data Pack [high priority]
	at TRANSFORMER/[email protected]/net.minecraft.resources.RegistryDataLoader.m_255048_(RegistryDataLoader.java:147)
	at TRANSFORMER/[email protected]/net.minecraft.resources.RegistryDataLoader$RegistryData.m_254786_(RegistryDataLoader.java:161)
	at TRANSFORMER/[email protected]/net.minecraft.resources.RegistryDataLoader.m_254785_(RegistryDataLoader.java:63)
	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
	at TRANSFORMER/[email protected]/net.minecraft.resources.RegistryDataLoader.m_247207_(RegistryDataLoader.java:62)
	at TRANSFORMER/[email protected]/net.minecraft.server.WorldLoader.m_246152_(WorldLoader.java:54)
	at TRANSFORMER/[email protected]/net.minecraft.server.WorldLoader.m_245736_(WorldLoader.java:58)
	at TRANSFORMER/[email protected]/net.minecraft.server.WorldLoader.m_214362_(WorldLoader.java:31)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.worldselection.CreateWorldScreen.m_232896_(CreateWorldScreen.java:125)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.worldselection.SelectWorldScreen.m_279861_(SelectWorldScreen.java:60)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.components.Button.m_5691_(Button.java:38)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.components.AbstractButton.m_5716_(AbstractButton.java:55)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.components.AbstractWidget.m_6375_(AbstractWidget.java:175)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.components.events.ContainerEventHandler.m_6375_(ContainerEventHandler.java:38)
	at TRANSFORMER/[email protected]/net.minecraft.client.MouseHandler.m_168084_(MouseHandler.java:92)
	at TRANSFORMER/[email protected]/net.minecraft.client.gui.screens.Screen.m_96579_(Screen.java:437)
	at TRANSFORMER/[email protected]/net.minecraft.client.MouseHandler.m_91530_(MouseHandler.java:89)
	at TRANSFORMER/[email protected]/net.minecraft.client.MouseHandler.m_168091_(MouseHandler.java:189)
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.execute(BlockableEventLoop.java:102)
	at TRANSFORMER/[email protected]/net.minecraft.client.MouseHandler.m_91565_(MouseHandler.java:188)
	at MC-BOOTSTRAP/[email protected]+7/org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
	at MC-BOOTSTRAP/[email protected]+7/org.lwjgl.system.JNI.invokeV(Native Method)
	at MC-BOOTSTRAP/[email protected]+7/org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474)
	at TRANSFORMER/[email protected]/com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237)
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1173)
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718)
	at TRANSFORMER/[email protected]/net.minecraft.client.main.Main.main(Main.java:218)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111)
	at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99)
	at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:108)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:78)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141)
Caused by: java.lang.RuntimeException: Not a JSON object: "minecraft:oak_log"
	at MC-BOOTSTRAP/[email protected]/com.mojang.serialization.DataResult.lambda$getOrThrow$5(DataResult.java:101)
	at MC-BOOTSTRAP/[email protected]/com.mojang.datafixers.util.Either$Right.map(Either.java:99)
	at MC-BOOTSTRAP/[email protected]/com.mojang.serialization.DataResult.getOrThrow(DataResult.java:93)
	at TRANSFORMER/[email protected]/net.minecraft.resources.RegistryDataLoader.m_255048_(RegistryDataLoader.java:143)
	... 41 more

[02:32:36] [Render thread/ERROR]: Reported exception thrown!
net.minecraft.ReportedException: mouseClicked event handler
	at net.minecraft.client.gui.screens.Screen.m_96579_(Screen.java:444) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.MouseHandler.m_91530_(MouseHandler.java:89) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.MouseHandler.m_168091_(MouseHandler.java:189) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.util.thread.BlockableEventLoop.execute(BlockableEventLoop.java:102) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.MouseHandler.m_91565_(MouseHandler.java:188) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) ~[lwjgl-glfw-3.3.1.jar%23141!/:build 7]
	at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.3.1.jar%23153!/:build 7]
	at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474) ~[lwjgl-glfw-3.3.1.jar%23141!/:build 7]
	at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1173) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.main.Main.main(Main.java:218) ~[forge-47.3.29.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.3.29.jar:?]
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99) ~[fmlloader-1.20.1-47.3.29.jar:?]
	at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25) ~[fmlloader-1.20.1-47.3.29.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?]
Caused by: java.lang.IllegalStateException: Failed to load registries due to above errors
	at net.minecraft.resources.RegistryDataLoader.m_247207_(RegistryDataLoader.java:77) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.server.WorldLoader.m_246152_(WorldLoader.java:54) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.server.WorldLoader.m_245736_(WorldLoader.java:58) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.server.WorldLoader.m_214362_(WorldLoader.java:31) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.gui.screens.worldselection.CreateWorldScreen.m_232896_(CreateWorldScreen.java:125) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.gui.screens.worldselection.SelectWorldScreen.m_279861_(SelectWorldScreen.java:60) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.gui.components.Button.m_5691_(Button.java:38) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.gui.components.AbstractButton.m_5716_(AbstractButton.java:55) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.gui.components.AbstractWidget.m_6375_(AbstractWidget.java:175) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.gui.components.events.ContainerEventHandler.m_6375_(ContainerEventHandler.java:38) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.MouseHandler.m_168084_(MouseHandler.java:92) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	at net.minecraft.client.gui.screens.Screen.m_96579_(Screen.java:437) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
	... 26 more

I use:
minecraft 1.20.1
forge 47.3.29
terrafirmacraft 3.2.13
kubejs 2001.2.3-build.6
kubejs-tfc 1.2.3

commented

I've finally figured out what's wrong... the tag registry should be worldgen/placed_feature, without the s, I'll fix the wiki shortly