KubeJS UI

KubeJS UI

6M Downloads

Accesses Mod Menu internals instead of using the API

Prospector opened this issue ยท 1 comments

commented

This here should use ModMenuApi.createModsScreen instead of invoking internal code directly. Also, I would recommend when you do this to update to Mod Menu > 1.15.0 which has a new package name for the API (old one still exists but is deprecated. It seems you haven't updated to a version on the new maven yet, so that is now here: https://maven.terraformersmc.com/com/terraformersmc/modmenu

Make sure to also include

"breaks": {
   "modmenu": "<1.15.0"
}

in your fabric.mod.json so people are running an up-to-date mod menu version that has the new API.

commented

Oh wow, I was actually just made aware of this as I went to fix the "issue" of mod menu migrating packages, I'll be sure to include this in my PR (sorry, I don't have push access to this repo yet and thus also don't get notifs for it either)

Actually, would you mind if we maybe moved the modmenu actions for KJS UI to modmenu itself, since it's basically just a JSON file and a single Consumer<Screen> (that you may already have elsewhere anyways)