KubeJS

KubeJS

61M Downloads

[1.18.2] Integrated Dynamics squeezer recipes with tag inputs cannot be loaded

TheLMiffy1111 opened this issue ยท 10 comments

commented

Minecraft Version

1.18.2

KubeJS Version

kubejs-forge-1802.5.1-build.331

Rhino Version

rhino-forge-1801.1.9-build.135

Architectury Version

architectury-forge-4.1.41

Forge/Fabric Version

forge-1.18.2-40.1.19

Describe your issue

image
Integrated Dynamics recipes that have their outputs described by tags are unable to be parsed by KubeJS and do not fallback to vanilla, therefore not being loaded. This seems to be caused by tags being empty during recipe loading in 1.18.2.

Crash report/logs

No response

commented

Issue is resolved in build.403

commented

You're... pretty far behind on KubeJS versions here. I did my best at fixing tags inside of KubeJS in this commit df20a51 (build.375), and in general, ID recipes have been a major pain point for a while, so I'd have to recheck whether things are still broken

commented

will check with build.395

commented

Issue persists with build.395

commented

Hmm, could you give me some example recipe JSONs of squeezer recipes? I have a feeling ID's recipe structure may have changed significantly, which would break with our custom RecipeJS

commented

https://github.com/CyclopsMC/IntegratedDynamics/blob/master-1.18/src/main/resources/data/integrateddynamics/recipes/squeezer/ore/raw_iron.json

Currently recipes are deserialized before the tag context is set, and I think that is what caused the issue

commented

Given that the tag context is technically ready before deserialisation, I could probably move that call up a little, let me test it out (also disregard that current "fix" commit it's mostly a refactor of ItemStackJS to account for result ingredients with chance)

commented

^ That above commit should be ready to be downloaded off Maven in about 3-5 minutes, mind giving that a try when it's ready?

commented

d91be73#diff-4a2d5685cbdaadb1d8342557be86efcffa2c61bf0deb3ba00655f21e73d44d44L482

The fix doesn't work yet as it seems like like this line was accidentally deleted making it always returning empty