lOwOcalizatiωn

lOwOcalizatiωn

9.4k Downloads

Conflicts with HammerLib/HammerCore 1.12.2

Psycheux opened this issue · 6 comments

commented

Hello, I wanted to add this mod cause it seemed silly but it seems to have compatibility issues with the modpack im using. After some trouble shooting I have seemed to bring it down to just HammerLib (Formerly HammerCore ig). I have tried the 3 newest versions of HammerLib for Minecraft Forge 1.12.2 and ive even tried different forge versions to nyo avail. I am unsure as to why this would cause any issues honestly and am just curious if maybe there is a way to fix it. Thank you in advance! ^w^

(attatched is a screencap of the console/log while loading, my mods folder with JUST HammerLib and lOwOcalization, and my minecraft nyot responding)

screencap_3_218

commented

i should also add, after it hangs like this for a while it just straight up crashes.

commented

Thanks a lot for the investigation and the report.

The issue seems to be that HammerLib's implementation of its language shenanigans is incompatible with the way this mod works. Specifically, this mod injects a custom implementation of Map that applies transformations (the OwOs) dynamically to fetched strings, and wraps the underlying storage of a ClientLanguage when it is constructed. However, HammerLib replaces this with a HashMap that it exposes for modification. It seems to do this to post a language event that can insert additional translations. I'm not sure where exactly it hangs and crashes, it's not hugely important but the crash log would help give more info.

I'm not sure enough about the specific workings and uses of HammerLib (and, crucially, don't remember well enough the details of the Minecraft code) to think of a way that I can fix this on my end; I would likely have to entirely overhaul where I apply the transformations. I might be missing something quite obvious though, since I haven't looked at the Minecraft code in a while, so I might check.

@Zeitheron I wonder if you have any ideas? Would it be possible to move your event to modify the language map earlier? If you're willing to add some code to fix the compatibility more directly, you could also perhaps extract and modify the underlying map by reflection. If you have any ideas for what I could do I'd also be happy to hear them.

commented

It looks like ClientLanguage now has an easier hook for me to use to modify translations, I'll do away with the map and see if it still works.

commented

Sorry, I entirely missed that you're on 1.12, I'll have to look around more.

commented

Ill get a fresh log so i can make sure that i have just those two mods enabled (so there's less clutter.). I appriciate the very quick response!! ^w^
im sorry that it's a possibly difficult or just odd issue .

commented

crash-2024-02-21_14.09.09-client.txt
okei, so after 52 mins and 13 secs of being frozen at bootup i have a fresh crash log xD

it appears it's trying to say it's a memory error, but it did the same thing even with more memory before so im unsure if that's REALLY the reason.