LagGoggles

LagGoggles

9M Downloads

Update Mixin version

BluePyros opened this issue ยท 10 comments

commented

Description:

Any mod that requires a newer version of Mixin (0.7.10) causes minecraft to crash before even really launching because LagGoggles is packaged with 0.7.5

How to reproduce:

Example mods:

Stargate Network
LagGoggles

Stacktrace, if any:

Crash report:

Console log:

https://pastebin.com/ZLB0Fabk

Other notes:

commented

Try the SpongeForge version instead of Forge.
The spongeforge version does not ship its own mixin.

commented

At first, Tiquality was meant to replace LagGoggles all together (Why try and hunt lag down when you can fix it forever?)

But then Tiquality grew into something new (and beautiful!). It become insanely optimized and highly specific.

In the LagGoggles rewrite, I will hook into Tiquality if it's present. If it is not present, it will still function as usual.
The Tiquality profiler at current is very bad (unusable almost). This is because I intend to let LagGoggles handle this later on.

I used to use Tiquality, But every time i added a new mod. Everyone on the server had to replace their Machine, this was annoying players.

Which version of Tiquality did you use back then? Was it one of alpha or beta releases? If it's in the latest release this needs a closer look.

commented

and what if you do not use sponge?

I can no longer do 30 second scans because it times my server out each and every time. Not the actual scan but when it is compiling Meaning i get a lot of false positives. That and theres is an issue with the current version of ATM3 Remix (1.1.0) that is causing even more false positives

commented

I have messed up the name scheme back when I started making releases.

The only difference between the SpongeForge version and the Forge version is that Mixin is embedded in the final jar or not. Back then I figured it would be easier for 'newbies' to understand what download version to pick. LagGoggles should be able to handle newer versions of mixin assuming there's backwards compatibility


The actual code explaining it
:

dependencies {
    compile 'org.spongepowered:spongeforge:1.12.2-2586-7.1.0-BETA-2865'
    if(isSponge) {
        compile 'org.spongepowered:mixin:0.7.4-SNAPSHOT'
    }else{
        embed('org.spongepowered:mixin:0.7.5-SNAPSHOT') {
            exclude module: 'launchwrapper'
        }
    }
}

If you look at Tiquality, you'll see that I have changed the name scheme to FAT and THIN. LagGoggles will also move to that name scheme later on, at the costs of people having to actually read before choosing a download.

As for the false positives, that will be addressed in the rewrite.

commented

I used to use Tiquality, But every time i added a new mod. Everyone on the server had to replace their Machine, this was annoying players. That and to my knowledge you can see a visual representation of lag with Tiquality. Something i really do like. (Unless i am mistaken here)

Are you doing a rewrite of LagGoogles as its own separate mod or integrating it into Tiquality? I hope you keep them separate but can be used together (As long as the issue i stated about adding new mods is fixed) As it would be the best lag prevention and finder como out there.

commented

TBH even if you only had Tiquality that fixed the lag. It would still be nice for those that are being for all intents and purposes punished for causing lag to be able to figure out what is causing the lag in there bases and be able to fix it so that they stop being punish.

It was pretty recent. Within the last month and a half. Unsure if that would be alpha or beta builds. I should have reported it being honest.

As a server owner, i love LagGoogles and it's a flipping awesome mod that has helped me massively within figuring out what is causing lag and to have one of the if not the best ATM3 Remix servers out there right now. (And that's not just me saying that, that came from one of the pack devs :D ) So thank you for your awesome mod and time you have put into it. I hope it becomes even more and you get a lot of support for this mod.

commented

TBH even if you only had Tiquality that fixed the lag. It would still be nice for those that are being for all intents and purposes punished for causing lag to be able to figure out what is causing the lag in there bases and be able to fix it so that they stop being punish

This is planned :)

As a server owner, i love LagGoogles and it's a flippin

Good to hear! It's nice to see one of my tools being put to good use.
I plan on removing all false positives in the rewrite, making it easier to use.

commented

That would be great. any ETA on it coming out? Ie where are you in development.

I used to be able to do 30 second scans, but for some reason that stopped and i can only do 15 seconds with a lot of lag at the end without it timing everyone out of the server. So this would be awesome to have out, so i can use it :)

commented

There's no ETA yet. Tiquality has priority because I believe that having a universal approach in fixing lag is better than having staff members go out to hunt lag every hour.

However, I have started LagGoggles development but there's a lot of work that needs to be done before I will release the new version. People expect the new LagGoggles version to be better than the old one right off the bat, so I am competing with myself, basically.

commented

Yeah it would be good to have, just thinking on how players would know that they are causing lag and being punished for it. Would players that are having there TPS dropped be told that's why they are getting slower response times? That would also save on the, why is there so much lagggggg. when it is because of how they are building.
Just a in chat message every 10 15 mins says that their tps is being reduced because of xxx would be nice and then explaining what they can do about fixing it would be sweat.

It's good that it's been started, don't want to make you feel pushed or anything. Would prefer something that works than someone that is broken due to being pushed to release.