LagGoggles

LagGoggles

Mods
9M Downloads

Laggoggles needs another update to work with Spongeforge 7.1.7.RC3886

Addalyn opened this issue ยท 11 comments

commented

Spongeforge 7.1.7 RC3886 has updated its bridge names once again so laggoggles need another update to work with it

https://gist.github.com/Alexandrea/d630a17b02d373de63b62afab9ad17e4

See SpongePowered/Sponge#2344 (comment)
acording to Zidane this is the last time they update the bridge names

commented

I've been holding off upgrading SpongeForge on my server just because of this bug. Any updates on the rewrite progress?

commented

Are you sure you're on the latest version? (LagGoggles-XXX-1.12.2-4.8.jar)

Edit: You are one 4.6 still, I just tested 4.8, and it works on the latest sponge version :)

commented

@TerminatorNL Except that i already updated to 4.8 LagGoggles-THIN-1.12.2-4.8.jar

(sorry just din't apply the new log for that)
https://gist.github.com/Alexandrea/d33e2161dba1634e53e2eb0c882df44c

[10:39:05] [Server thread/FATAL] [laggoggles]: To prevent you from wasting your time, the process has ended.
[10:39:05] [Server thread/FATAL] [laggoggles]: 
[10:39:05] [Server thread/FATAL] [laggoggles]: Required mixins that have not been applied:
[10:39:05] [Server thread/FATAL] [laggoggles]: - cf.terminator.laggoggles.mixin.MixinWorldServerSponge targeting: net.minecraft.world.WorldServer
[10:39:05] [Server thread/FATAL] [laggoggles]: 
[10:39:05] [Server thread/FATAL] [laggoggles]: This means that LagGoggles will not function properly.
[10:39:05] [Server thread/FATAL] [laggoggles]: Make sure your versions are correct for Forge as well as SpongeForge.

As side note so dos Tiquality (but ShadowKitten manually patched it herself for now so for us it works)

commented

Tiquality introduced this crash, LagGoggles was just the first to report it. I have just now updated Tiquality. Did you try the newest version?

[10:36:27] [main/WARN] [mixin]: Mixin apply failed mixins.tiquality.json:MixinWorldServerSponge -> net.minecraft.world.WorldServer: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException Unexpecteded NullPointerException whilst applying the mixin class: null
org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: Unexpecteded NullPointerException whilst applying the mixin class: null
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:292) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:353) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.apply(MixinTransformer.java:724) [malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.applyMixins(MixinTransformer.java:703) [malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:509) [malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.Proxy.transform(Proxy.java:72) [malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:279) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:176) [launchwrapper-1.12.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424) [?:1.8.0_201]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357) [?:1.8.0_201]
	at java.lang.Class.getDeclaredMethods0(Native Method) ~[?:1.8.0_201]
	at java.lang.Class.privateGetDeclaredMethods(Class.java:2701) [?:1.8.0_201]
	at java.lang.Class.privateGetMethodRecursive(Class.java:3048) [?:1.8.0_201]
	at java.lang.Class.getMethod0(Class.java:3018) [?:1.8.0_201]
	at java.lang.Class.getMethod(Class.java:1784) [?:1.8.0_201]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:132) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_201]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_201]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_201]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_201]
	at net.minecraftforge.fml.relauncher.ServerLaunchWrapper.run(ServerLaunchWrapper.java:70) [forge-1.12.2-14.23.5.2838-universal.jar:?]
	at net.minecraftforge.fml.relauncher.ServerLaunchWrapper.main(ServerLaunchWrapper.java:34) [forge-1.12.2-14.23.5.2838-universal.jar:?]
Caused by: java.lang.NullPointerException
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformSingleDescriptor(MixinTargetContext.java:909) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformDescriptor(MixinTargetContext.java:865) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformTypeNode(MixinTargetContext.java:654) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformMethod(MixinTargetContext.java:471) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyNormalMethod(MixinApplicatorStandard.java:445) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMethods(MixinApplicatorStandard.java:432) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:312) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:280) ~[malisiscore-1.12.2-6.5.1.jar:1.12.2-6.5.1-SNAPSHOT]
	... 22 more
commented

Ye still issue with laggoggles 2.4.8 and using Tiquality-THIN-1.12.2-GAMMA-1.5.8.jar now

https://gist.github.com/Alexandrea/660acad7e1ccd12a281c4664863397ea

commented

I reproduced the error. On it!

commented

Unfortunately, There's an incompatibility with LagGoggles and Tiquality.

LagGoggles gives unreliable results when Tiquality is installed due to method redirection. Here's what I am talking about:

  1. SpongeForge overwrites the method body: org.spongepowered.common.mixin.core.world.WorldServerMixin#updateBlocks and org.spongepowered.common.mixin.core.world.WorldServerMixin#tickUpdates
  2. LagGoggles redirects Block.updateTick and Block.randomTick methods inside that body to itself and wraps it in a timer
  3. Tiquality redirects the redirected Block.updateTick and Block.randomTick and performs logic on them to either queue and return, execute the entire queue until time runs out which may or may not involve the scheduled block update.

This is fundamentally flawed. At the moment, there's no way to know if the block actually updated, or was placed in a queue, or executed the entire queue in that same update. This leads to times being extremely low or high for a few blocks placed in the world, and do not represent the true time of the block update itself.

I implemented that part of LagGoggles already for the next mayor version, but the old version (this one) does not support this yet.

This also means that when previous versions of LagGoggles and Tiquality were installed together had the same fundamental flaw, it's only now that it introduces a true incompatibility error.

I will prioritize the LagGoggles rewrite over mayor Tiquality updates to address this. This means that, for now, these mods are incompatible.

commented

Try SpongeForge with the latest version of LagGoggles now.

commented

Recently I'm running into crashes when I start profiling with latest version of SpongeForge and the mod. IDK should open a new issue but I'll post the log here anyway since it looks it's compatibility problem with Sponge
https://gist.github.com/ken1882/fae60113ffd94188701ac708d4a250ef

commented

oh yeah @ken1882 that's a new issue, and must be directed towards SpongeForge. This one has been fixed for a while now, closing!