Large Fluid Tank

Large Fluid Tank

4M Downloads

[Fabric] [Rending Bug] Fluid not displayed in large tanks

milkev opened this issue ยท 6 comments

commented

Fluids in the larger tanks do not render a layer at the bottom until it reaches a certain % of the max.
It would be nice if there was the smallest layer rendered if the fluid amount is at a point its not displayed at all. This will make tanks easier to read at a glance, and without the use of HWYLA, you will actually know whats in the tank.

commented

Do you mean fluids in tank are not shown like pictures in this page?
Recently, I'm not working on Fabric version 1.16, so it may have changes in rendering system.

commented

Fluids usually render as normal, however in the larger tanks there seems to be a certain amount of fluid the tank must be holding before any fluid is rendered.
If you fill it up enough, fluid does start to render, however with large tanks like the star tank, you need a huge amount of liquid before you even get the small layer at the bottom of the tank.
This is easily reproducable by placing a star tank, and placing a few buckets of fluid in it, or a few hundred buckets of fluid...
I suspect this is present on forge as well, however I can't test as I do not use forge 1.16

commented

OK. I misunderstood your first comment.
You think it'll be nice if star tank holding just 1 bucket shows its content, now it doesn't show water or lava until the tank holds 1% of capacity.

Now the rendering is intended (working completely as I wrote in the source code), but can be improved.

commented
commented

sorry i didnt end up being able to check it myself until today.
Fluids straight up no longer show in the tanks. Tested only using fabric api, fluid tanks, and its dependencies on 1.16.5.
the silver and wood tanks are full of water, the star tank has a few buckets of water in it. lava yielded the same result.
edit: i had forgotten to check, but i am running the latest version of fabric api, this mod, and its dependencies.
2021-01-28_21 11 11
2021-01-28_21 10 32

commented

It was a problem related with graphic mode, "Fabulous" and translucent textures. Changing to fancy will resolve this problem, but I upload new file to change render mode to Cutout when Fabulous and Translucent when fancy or fast.