Large Fluid Tank

Large Fluid Tank

4M Downloads

[Feature Request] Add Variant Condition for Tanks

mouse0270 opened this issue ยท 6 comments

commented

I was curious if it was possible to add some sort of tag to the tanks for if they were single tank, the bottom piece, the top piece or the middle pieces, so that I could have more control over the tanks models.

Something like

  • position: single if a single tank.
  • position: bottom If the tank has a tank above it
  • position: top if the tank has a tank below it but not above it
  • position: middle if the tank has a tank below and above it.

For example, these are my new models. The reason I am requesting this feature is because I could then use that feature in the blockstates to have a tank.json, tank-bottom.json, 'tank-middle.jsonandtank-top.json` so that for the middle sections you would have the break and instead the glass would go straight up to the top.

Basically, this is a feature request for a resource pack, ignore it if you like... I can live with my current changes if I have to but thought I would request it if possible.

commented

I am going to leave this open incase you want to review it and decide if you want to include this. I actually found a mod that is basically doing this and looks almost identical to the fluid container I created in block bench.

If you don't want to include this, just close this.

commented

So I am to stupid to figure out how to build your pull request, but if you like I can send you my models and textures that I was designing?

The new models use mostly base Minecraft textures and the glass particle. So they should scale with resource packs a lot nicer.

Here is an example, I changed star to use the obsidian portal texture/animation and then just threw in a random light-purple > light-blue > light purple animation for the creative tank.
image

I am working on adding a little line indicators like you have on your textures but haven't gotten to that point. I am actually waiting to use your mod now, cause the one I am using looks nicer, functions worse.

commented

Yeah that causes a slight visual issue as shown in this image, but I like the design of the tanks so much more.

image

The Gold/Diamond/Emerald tank has 251000mb of liquid in it, but since my model has a base, its not visible yet.... Not the worst thing and something I am will it give up from the nicer models.

Thanks for adding this feature so I could do this, your fluid tanks are the most flexible and I am happy to use them.

commented

Released v16.1.7

commented

See here for the available option of tanks.
I think you can use your own model by change the entry model.
Be careful that the renderer of content(fluid) is hardcoded so the rendering box of fluid can't be modified from resource packs.

commented

The "height" of fluid is determined by the amount of fluid in tank. It is 0.003 < height < 0.999 now. (I got some requests to show fluid even if tank has less than 0.1 % of fluid so I applied lower limit of 0.003)
It seems that the base in your texture has 1 / 16 height, then the lower limit should be (1 / 16 + epsilon), where epsilon is a small number to avoid flicker of texture.
I'll make it possible to change the lower limit from config.