LaserIO

LaserIO

21M Downloads

Add Mekanism Gas Card

bruno-borges-2001 opened this issue ยท 5 comments

commented

Describe the feature you'd like to have added

I think a compatibility with Mekanism's Gases would be great (like with Gas Cards and filter support)

Additional information

No response

commented
commented

Hi guys, I'm working on this request ๐ŸŽ‰.

Currently I've figure out how to extract and insert gases.

But I need more time to test more features like stock and filters.

When the Gas Card become stable, I'll open a PR to @Direwolf20-MC check what I did and if is good to go :)

commented

@MichaelHillcox and @Direwolf20-MC , I've added you both to my repository. There you will find the feature/add-mekanism-gas-card branch with a 98% functional version.

There are some points that I wasn't able to figure out yet, they are:

  • File: EventTooltip.java
    -> The tags collector from Mekanism is trick
  • File: FilterTagScreen.java
    -> Rendering a "bucket" or a "tank" is trick
  • File: BaseCardCache.java
    -> FilterMod and FilterTag wasn't implemented yet
  • File: GetStackKey.java
    -> Collecting NBT tags from Gas is trick
commented

Hay, thanks for working on this issue. Privately inviting us to your project is a little non-standard for this kinda thing. Once you have something ready, open up a Pull Request and we'll review

commented

Planned Feature :)