Legendary Tooltips [Forge]

Legendary Tooltips [Forge]

28M Downloads

[1.18.2] Noticed that items from Enigmatic Legacy don't have the divider line or centered names

vizthex123 opened this issue ยท 8 comments

commented

Seems to apply to every item in the mod, like you can see below
image
image

The item names also aren't centered
image
image

commented

If it only affects one mod, that mod is likely building the tooltips in a non-standard way so the onus would be on that mod's author. I will look into it to verify and get back to you.

commented

Ah yep, for some reason they are completely overwriting the tooltip generation here https://github.com/Aizistral-Studios/Enigmatic-Legacy/blob/66d03adba3bb840a4c4ea7d2382196590f5a8370/src/main/java/com/integral/enigmaticlegacy/handlers/EnigmaticEventHandler.java#L477-L599

I won't be able to fix it, but they should be able to if they just use normal methods to modify tooltips instead of what they are doing.

commented

Alright then, guess I can tell them about it.

commented

Similar issue with the mod apotheosis :
When I combine a gem with an item, things get weird, and I assume it's an incompatibility between legendary tooltips and apotheosis :
1
2

But I don't understand why it moves the button from the mod polymorph, it's possible that an other mod cause conflict

commented

more visible issue :
image

commented

Looks like Apotheosis forgot to revert the scale.
Edit: I don't know. SocketTooltipRenderer
Just leaving this here in case

commented

Looks like Apotheosis forgot to revert the scale. Edit: I don't know. SocketTooltipRenderer Just leaving this here in case

Sorry I haven't updated this issue, but I'm not really sure what you mean in your post. See the commit history on the file you have linked (Shadows-of-Fire/Apotheosis@2624034), I fixed the issue that was preventing the divider line from appearing among other problems.

When I tried Apotheosis and Legendary Tooltips together as soon as there is a gem socketed in an item it breaks the border decorations of Legendary Tooltips (and also the 'Add...' button of REI). That's the issue @Blugori showed.

I merely chimed in and looked through the source to find how Apotheosis renders sockets and gems... Sorry lol

commented

Looks like Apotheosis forgot to revert the scale. Edit: I don't know. SocketTooltipRenderer Just leaving this here in case

Sorry I haven't updated this issue, but I'm not really sure what you mean in your post. See the commit history on the file you have linked (Shadows-of-Fire/Apotheosis@2624034), I fixed the issue that was preventing the divider line from appearing among other problems.