Lib Network Stack

Lib Network Stack

Mods
43.2k Downloads

Multi-jar creation plugin creates invalid artifacts for production 1.19

Kneelawk opened this issue ยท 1 comments

commented

The Issue

Built artifacts generated by the Multi-jar creation plugin extra_jar_def.gradle crash when loaded in a production environment in Minecraft 1.19. Loading any class from a jar generated by the plugin seems to result in attempts to load Minecraft classes using the wrong class-loader, even if those classes are not referenced anywhere within the LNS class.

Here is an example crash-report: https://paste.ee/p/UGih0

If instead, the build artifact artifacts not produced by the Multi-jar creation plugin are used in the production environment, then the game functions as normal.

Reproducing

  • Load the libnetworkstack-base-0.7.0.jar jar produced by the Multi-jar creation plugin in a Minecraft 1.19 instance along with either fabric-api or QSL.
  • Game crashes: https://paste.ee/p/UGih0

Other Affected Libraries

This seems to affect all libraries using the Multi-jar creation plugin, including LBA, LMP, and LNS.

Other Notes

I noticed that the mixin.json files in the jars produced by the Multi-Jar Creation Plugin were lacking the refmap key and value. However, manually adding it did not fix the issue.

commented

The related PR has been merged, so I guess this can be closed now?