LibrarianLib

LibrarianLib

18M Downloads

[1.12.2] [4.19.2] BlockModLog class returns an empty charcoal furnace recipe

wamc2017 opened this issue ยท 4 comments

commented

Hi,

if Wizardry or Natural Pledge are installed alongside LibrarianLib (both mods are using the BlockModLog class to add their trees), a furnace recipe with empty input is added to the game.
charcoal

It seems "this" in the following line returns Block("Null") or something like this:

FurnaceRecipes.instance().addSmeltingRecipeForBlock(this, ItemStack(Items.COAL, 1, 1), 0.15f)

I guess those issues are related:
https://github.com/TeamWizardry/Wizardry/issues/298
TeamWizardry/Wizardry#295
Um-Mitternacht/Bewitchment#373

Thanks for looking into this.
Best regards,
wamc

commented

Oof. Lemme see if I can resolve the couple notes so we can get that merged.

commented

The issue might be that code being called before the ItemBlock is registered. I'm looking into it.

commented

This isn't the first time it's been brought up, Wire said it had been fixed but apparently not

commented

Haven't seen this pull request: #112

I guess those should address this issue...