indicator disappears from certain camera angles/distances with shaders
Avera9eJoe opened this issue · 22 comments
I noticed that running with any shaders makes this mod very difficult to use as the lines disappear at different angles or distances away, and they also seem to have shader lighting applied to it, I.E. they're really dim. Is there a fix for this I'm not seeing, or is this not meant to be used with shaders?
Also seems to be an issue with Iris, where both the numbers and crosses aren't visible at all. Wanted to note it here since as opposed to Optifine the source code of Iris seems to be available should someone want to investigate the issue further.
This is fixed on the side of Iris in https://github.com/IrisShaders/Iris/tree/1.16.x/refactor/bulletproof-state-tracking and this fix will be included in a future Iris release.
Of course, OptiFine compatibility will still be broken, but clearly that is an OptiFine issue, not an issue with Light Overlay.
Is this a "definitely won't fix" or would pictures and other info help?
Thanks for creating the mod though, much appreciated.
The newest updates seem to have fixed the camera angles bug, but there is another issue with certain shaders making the overly very dark:
Image of LightOverlay on with no shaders
Image of LightOverlay on with sildur's enhanced default
Its almost as if something in the pack is being drawn on top of the light overlay. I noticed that shaders also make the outlines caused from structure blocks to get very dim as well. I think this issue is bigger than just LightOverlay though, so it isn't anything you have to worry about.
How about the vanilla included chunk borders, are they dim as well? Light Overlay is similar to that.
I tested the chunk borders and it has the exact same problem. I don't use them that often and didn't notice before, but it does the exact same thing. Optifine internal shaders look fine, so maybe it's more on the individual shader developers. I've only tested Sildurs shaders. If you're interested, I could try some others.
I'm using all the latest versions (see below). Here are screenshots. These were all taken from the same position with slight adjustments to the view angle. While walking around, the lines flicker between the black lines, the red lines, and nothing. I say "flicker" but it's angle dependent and often stays as one color for a second or two as you're walking around.
(Edited to add image labels)
No Shaders
Optifine Internal Shaders
Sildurs Enhanced Default Shaders With Missing Overlay
Sildurs Enhanced Default With All Black Lines
Sildurs Enhanced Default With All Red Lines
Sildurs Enhanced Default Shaders - Chunk Border and Light Overlay With Black Lines
Minecraft 1.14.3
Fabric Loader 0.4.8 build 155-1.14.3
Fabric API 0.3.0 build 188
LightOverlay 1.2.1
ModMenu 1.5.4-85
OptiFabric 0.3.2
OptiFine 1.14.3_HD_U_F1
Windows 10
Unfortunately I don’t have a good way to fix this as the vanilla chunk borders are affected as well.
Yea, I don't think you should worry about it either. I'd say your mod works perfectly and it's a bug with the shader packs and how MC implements overlays like chunk borders. I'll see what the shader community has to say.
Thanks again!
I agree with Web4Guru, I don't think its a big enough issue to worry about. Its good that we're aware of it though.
This issue could perhaps be fixed by changing the crosses to be rendered with whatever method is being used to render the numbers? I'm assuming it's some kind of decal texture.
I have some news I wanted to share. I ran Minecraft 1.16.1 with Fabric, Optifine, Optifabric, Fabric API and Mod Menu and Light Overlay, and I found out something very interesting and useful. If you have a beacon with a beam, I actually got the lines to work with shaders as long as the beam was in render distance. I tested it and it worked normally for Sildurs Vibrant Shaders and BSL, but SEUS only showed the overlay on top of tall grass for some reason. So if you run Sildurs or BSL and have a beacon, you can use this with the lines mode when close enough to the beacon to see it.
Not sure if this is related, but Optifine and Sildurs recently fixed a bug where block outlines and break animations were only visible from certain angles.
Tested it, the lines are still buggy with shaders on. They're only visible in a 90° viewing direction range.
Just wanted to let you know that there is easy if not "nice" workaround, if you use the numbers overlay instead of the crosses it works perfectly with all the shaders I tried it with (all versions of SEUS, Sildur and Trilton compatible with 1.15) in 1.15.2 with fabric and optifine
It's not as nice looking but it's perfctly effective, hope this can help others with this issue.
