LightingWand versions 1.0.3 & 1.0.4 are both causing crashes on Minecraft 1.12.2
crabdancing opened this issue · 8 comments
See crash log here.
Edit: it was actually 1.0.3. But I just tested 1.0.4, and got the same result, so there is unlikely to be a regression between the two version numbers.
Tried wrapping contents of snownee.lightingwand.common.BlockLight.hasItem in a try ... catch, and it just breaks somewhere else. Tried removing all other mods, and it still breaks. Tried removing LightingWand, and the world loads fine, but without my awesome light wand. :(
I have a solution! Do you accept pull requests, @Snownee?
I don't know if you're planning on maintaining the 1.12.2 version. If you don't want to, I could always fork and maintain it for legacy modpacks. Please let me know!
I will but I am too busy these days. I accept PRs but it will be published few days later
Okay! How do I submit a PR for 1.12.2?
Edit: wait, it's the master branch? I just poked around in the repo, and noticed the master branch happened to have 1.12.2 in the gradle.properties...
Just wanted to check with you first, so I don't make a mistake!