LightWithin

LightWithin

695 Downloads

Icon position option in client config has no effect & command /light ready delay issue

czHimura opened this issue ยท 1 comments

commented

Describe the bug
1- light_xx_preset in lightwithin_client.yml has no effect. The positions of icons stay in the default top left corner.
2- Command /light ready <target> with argument [delay] works only once after the server starts.

To Reproduce

To change the icon position
1- Set the position option to light_ready_preset:BOTTOM_RIGHT in lightwithin_client.yml.
2- Reload client config by /light_client reload or relaunch game.
3- Execute command /light ready @s to see the light ready icon.

To use light ready with delay several times
1- Execute command /light ready @s 3.
2- After 3s, activate the light.
3- Wait until all the status effects expire or /effect clear.
4- Execute command /light ready @s 3 again.

Version information
LightWithin mod version: 1.1.3
Minecraft version: 1.20.1
Fabric API version: 0.92.3

Expected behavior

  1. Light ready icon appears in the bottom right corner.
  2. After 3s delay, the light is ready for the second time.

Screenshots and files
Issue1- none, easy to reproduce
Issue2- not critical

commented

For the first one, the presets only work while using YACL because when reloading the config, there is no way to know if you want to update the preset or the specific xy values (For example, if you change the preset to "TOP_LEFT" and then you put 15 as the light_ready_x, which one do I need to apply? Dunno). I'll specify better in the comment.

For the other issue, it has recently been fixed and will be in the next major release