Issue with easy place features
fsrastdyyf opened this issue · 23 comments
I'm having trouble with the easy place mod feature. Whenever I use it by placing some types of blocks (repeater, observer, etc.) the blocks are not placed on the server, and when exiting and re-entering the blocks there are no
What type of server is it? If it's a Spigot or Paper based server, it might have anti-cheat which prevents clicking on air blocks, which is how the Easy Place mode works.
Oh, yea... it's a Paper server.... Is there any method to disable it? until a few days ago this error did not occur. What can I recommend to the creator of the server, to make the Litematic usable?
Only the 1.12.2 version currently has the improved Easy Place code which has an option to only click on existing adjacent blocks. So you can't disable that behavior in the 1.13+ versions yet. As for the server, I have no idea where and by what name the option would be. But it's some kind of check for how/where the player is clicking, that the vanilla game does not do/care about.
I also have this issue. If you find the setting, please let me know :) I will do the same
i also have this problem with the easy place feature,whenever i use it by placing blocks such as stairs,those blocks are not placed on the server,and they are not when i exit and re-enter them.
Some mods on my Paper server have narrowed down the EasyPlace client desync (such as stairs not being placed) to this Paper commit.
PaperMC/Paper#6591
Litematica works fine on server versions before the commit and has issues with EasyPlace after.
Oh yeah if it's checking the x coordinate of the hit vector, then it can be "out of reach" in many cases, especially with blocks that have a rotation, because the Easy Place mode uses the so-called "Accurate Block Placement protocol" that Carpet mod introduced around 1.11 or 1.12 or whatever. The protocol basically encodes the requested block rotation and possibly some other properties (such as placing a trapdoor in the open state) into the hit vector x coordinate (on the client this is done by a mod such as Carpet Client, Tweakeroo or Litematica). Normally the vanilla server does not use that relative x value for almost anything. The protocol is also implemented such that it is possible to still give the vanilla code the correct relative hit position, but that obviously would need a server-side mod to strip away that extra encoded information, which would not happen for example on a Paper server.
So I might then need to add an option to not apply the accurate placement protocol at all. But that would mean that none of the blocks would get auto-oriented. Then again on a Paper server where that option would be relevant that would not happen anyway...
Oh yeah I had forgotten that I think the Easy Place mode currently uses a reach distance of 6 instead of the normal 4.5 that vanilla uses. I should make that an option you can toggle off.
Just adding a note here that even if you are 1 block away, the server rejects easyPlace's attempt to place some types of blocks (stairs, repeaters, observers). It also doesn't matter if the schematic block is in air or on the ground.
However, fiddling with some configurations, if Schematic Rendering is turned off (M + G) and easyPlaceFirst is configured to false, those blocks can be placed.
Also, in survival, it seems you can place stairs if you are 4 blocks away from the schematic block.
Looking at the Paper patch, it is now validating movingobjectpositionblock.getLocation(). I'm not sure, but I think this translates in Litematica to the BlockHitResult object that is passed to mc.interactionManager.interactBlock
I compiled Litematica commenting out the code block below and Paper stopped rejecting the blocks:
// Carpet Accurate Placement protocol support, plus BlockSlab support
if (Configs.Generic.EASY_PLACE_PROTOCOL_V3.getBooleanValue())
{
hitPos = applyPlacementProtocolV3(pos, stateSchematic, hitPos);
}
else
{
hitPos = applyCarpetProtocolHitVec(pos, stateSchematic, hitPos);
}
Having an option to disable that extra encoding information would indeed be useful for Paper servers. Even before this patch, I know I had to disable easyPlace to be able to place certain doors and trapdoors to match the exact block state.
by not applying protocol, so its just hitPos. I'll try some additional checks for paper, it would be just one option. It will be great if there's some way to know if server is using protocol or not tho.
if (!Objects.equals(mc.player.getServerBrand(), "fabric")){
}
else if (Configs.Generic.EASY_PLACE_PROTOCOL_V3.getBooleanValue())
{
//System.out.println("applied v3");
hitPos = applyPlacementProtocolV3(pos, stateSchematic, hitPos);
}
else
{
//System.out.println("applied v2");
hitPos = applyCarpetProtocolHitVec(pos, stateSchematic, hitPos);
}
can do something like this, it will not apply protocol when its not fabric server. usually its performance difference is not really noticeable unless you're doing wierd stuff.
I compiled Litematica commenting out the code block below and Paper stopped rejecting the blocks:
// Carpet Accurate Placement protocol support, plus BlockSlab support if (Configs.Generic.EASY_PLACE_PROTOCOL_V3.getBooleanValue()) { hitPos = applyPlacementProtocolV3(pos, stateSchematic, hitPos); } else { hitPos = applyCarpetProtocolHitVec(pos, stateSchematic, hitPos); }Having an option to disable that extra encoding information would indeed be useful for Paper servers. Even before this patch, I know I had to disable easyPlace to be able to place certain doors and trapdoors to match the exact block state.
In which file did you comment that out?
its on utils/WorldUtils.java
In https://github.com/maruohon/litematica/blob/master/src/main/java/fi/dy/masa/litematica/util/WorldUtils.java?
Can't find that code block in there? What am I doing wrong haha
you're looking at wrong branch
I compiled Litematica commenting out the code block below and Paper stopped rejecting the blocks:
// Carpet Accurate Placement protocol support, plus BlockSlab support if (Configs.Generic.EASY_PLACE_PROTOCOL_V3.getBooleanValue()) { hitPos = applyPlacementProtocolV3(pos, stateSchematic, hitPos); } else { hitPos = applyCarpetProtocolHitVec(pos, stateSchematic, hitPos); }Having an option to disable that extra encoding information would indeed be useful for Paper servers. Even before this patch, I know I had to disable easyPlace to be able to place certain doors and trapdoors to match the exact block state.
With this implemented Easy Place Mode still doesn't work when you're pressing shift and building. Is there a fix that might make it work when you're pressing shift as well?
With this implemented Easy Place Mode still doesn't work when you're pressing shift and building. Is there a fix that might make it work when you're pressing shift as well?
As of versions 0903+, something changed regarding extra keys. Go to Configuration menu > Hotkeys. In easyPlaceUseKey, click on the image button before 'RESET', and change Allow extra keys to true.
Oh yeah I had forgotten that I think the Easy Place mode currently uses a reach distance of 6 instead of the normal 4.5 that vanilla uses. I should make that an option you can toggle off.
I've tested and changing from 6 to 4.5 is also very helpful, as Paper also rejects blocks placed far (even before this patch).
I did a screw up on PR #422 (merging into master instead of the 1.17 branch), hopefully that can be fixed?
I compiled Litematica commenting out the code block below and Paper stopped rejecting the blocks:
// Carpet Accurate Placement protocol support, plus BlockSlab support if (Configs.Generic.EASY_PLACE_PROTOCOL_V3.getBooleanValue()) { hitPos = applyPlacementProtocolV3(pos, stateSchematic, hitPos); } else { hitPos = applyCarpetProtocolHitVec(pos, stateSchematic, hitPos); }Having an option to disable that extra encoding information would indeed be useful for Paper servers. Even before this patch, I know I had to disable easyPlace to be able to place certain doors and trapdoors to match the exact block state.
I've noted that placing top slabs from below become bottom slabs (therefore triggering wrong state). I suppose the code below from applyCarpetProtocolHitVec would be needed, as it only shifts 0.9 in the Y coordinate:
else if (block instanceof SlabBlock && state.get(SlabBlock.TYPE) != SlabType.DOUBLE)
{
//x += 10; // Doesn't actually exist (yet?)
// Do it via vanilla
if (state.get(SlabBlock.TYPE) == SlabType.TOP)
{
y = pos.getY() + 0.9;
}
else
{
y = pos.getY();
}
}