Lithium (Fabric)

Lithium (Fabric)

Mods
22M Downloads

reuse `EntityShapeContext` instead of replacing it entirely

nnym opened this issue · 2 comments

commented

The problem
Currently LithiumEntityShapeContext replaces EntityShapeContext without extending it, with can cause incompatibilities with mods using EntityShapeContext specifically. (See user11681/paradox-slabs.)

The solution
Have LithiumEntityShapeContext extend EntityShapeContext or apply the optimizations in LithiumEntityShapeContext to EntityShapeContext directly with Mixin.

commented

That makes sense. I will do that

  • 👍2
commented

That makes sense. I will do that

Just a reminder to close this if ec7776f is where you implemented this.