Incompatible with Arcana Novum on 1.3.5+
suerion opened this issue · 9 comments
Hey, i had an issue after updating to 1.4, had disabled CTOV and tried to clean the server, Clean Startup and so on.
-> Server Crash on Startup
[02:38:36 INFO] [Server thread]: [DedicatedServer] Preparing level "world"
[02:38:36 ERROR] [Server thread]: [MinecraftServer] Encountered an unexpected exception
java.lang.ClassCastException: class net.minecraft.class_3545 cannot be cast to class com.mojang.datafixers.util.Pair (net.minecraft.class_3545 and com.mojang.datafixers.util.Pair are in unnamed module of loader 'knot' @7e9131d5)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
at knot/net.minecraft.world.level.levelgen.structure.pools.StructureTemplatePool.compileRawTemplates(StructureTemplatePool.java:2035) ~[?:?]
at knot/dev.worldgen.lithostitched.worldgen.modifier.internal.CompileRawTemplatesModifier.applyModifier(CompileRawTemplatesModifier.java:23) ~[lithostitched-fabric-1.21.1-1.4.jar:?]
at knot/dev.worldgen.lithostitched.worldgen.modifier.Modifier.applyPhaseModifiers(Modifier.java:83) ~[lithostitched-fabric-1.21.1-1.4.jar:?]
at knot/dev.worldgen.lithostitched.worldgen.modifier.Modifier.applyModifiers(Modifier.java:57) ~[lithostitched-fabric-1.21.1-1.4.jar:?]
at knot/net.minecraft.server.dedicated.DedicatedServer.handler$gbi000$lithostitched$applyModdedBiomeSlices(DedicatedServer.java:2716) ~[?:?]
at knot/net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:185) ~[?:?]
at knot/net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:664) ~[server-intermediary.jar:?]
at knot/net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:281) ~[server-intermediary.jar:?]
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
Crashlog:
https://mclo.gs/vNXVIgu
Latest.log:
https://mclo.gs/uh9Libt
@Apollounknowndev had added on Arcana Novum the issue,
Latest.log
https://mclo.gs/1LmCnp8
Crash Log:
https://mclo.gs/JZdmPxr
[15:52:33 ERROR] [Server thread]: [MinecraftServer] Encountered an unexpected exception
java.lang.IllegalStateException: Expected a Pair but got a Tuple. ID of pool element was found to be: arcananovum:village/desert_arcanists_house
at knot/net.minecraft.world.level.levelgen.structure.pools.StructureTemplatePool.md8c1364$lithostitched$lambda$compileRawTemplates$0$0(StructureTemplatePool.java:2039) ~[?:?]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
at knot/net.minecraft.world.level.levelgen.structure.pools.StructureTemplatePool.compileRawTemplates(StructureTemplatePool.java:2034) ~[?:?]
at knot/dev.worldgen.lithostitched.worldgen.modifier.internal.CompileRawTemplatesModifier.applyModifier(CompileRawTemplatesModifier.java:23) ~[lithostitched-fabric-1.21.1-1.4-bug27.jar:?]
at knot/dev.worldgen.lithostitched.worldgen.modifier.Modifier.applyPhaseModifiers(Modifier.java:83) ~[lithostitched-fabric-1.21.1-1.4-bug27.jar:?]
at knot/dev.worldgen.lithostitched.worldgen.modifier.Modifier.applyModifiers(Modifier.java:57) ~[lithostitched-fabric-1.21.1-1.4-bug27.jar:?]
at knot/net.minecraft.server.dedicated.DedicatedServer.handler$gbj000$lithostitched$applyModdedBiomeSlices(DedicatedServer.java:2716) ~[?:?]
at knot/net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:185) ~[?:?]
at knot/net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:664) ~[server-intermediary.jar:?]
at knot/net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:281) ~[server-intermediary.jar:?]
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
This appears to be a conflict with another mod with some sketchy code, but I'm not sure which one and MixinTrace isn't being helpful.
Here's a special version of Lithostitched 1.4 that logs some extra data. Run it on your instance and send the crash report and logs from it.
Arcana Novum dev here. I'll be completely honest and say that I am a bit out of my depth when it comes to worldgen stuff, the code that I used for injecting custom village houses into the pool is adapted from Structurized Reborn that I found in a Kaupenjoe tutorial. My initial guess is that Lithostitched is modifying the worldgen system to the point where the simple injects that Structurized's code does no longer works properly.
If this is something that should be fixed on my end, I would greatly appreciate some suggestions on what to do ^_^
This is an issue on Arcana Novum's end due to a subtle import error. A fix has been pushed to them here. This issue will remain open until they merge and release the patched version.
@borisshoes you could look on stonecutter https://github.com/stonecutter-versioning/stonecutter
Because Arcana is a server-sided mod that is attempting to match the level of content of other fully fledged magic mods like Thaumcraft or Mahou Tsukai, I am constantly looking for opportunities to use the latest data-driven features of the new updates to add features that were previously infeasible or impossible. This is why all versions of Arcana with new items or mechanics are done on the latest version of Minecraft with no backwards support planned, or even possible in most cases.
Only the 1.24.1 version would be fixed, i had created an fork from the 1.21.1 release and fixed the issue on my side,
https://github.com/suerion/ArcanaNovum
Branch1.21.1 would be update other issues later and will check the 3.0.6 commit from Original version, if i could update a little bit more to add latest changes. Hope i could help from my side.
@borisshoes you could look on stonecutter https://github.com/stonecutter-versioning/stonecutter
It helps to add multiversions :)
Please let the issue open, if someone get the problem on 1.21.1 yet